cleanup/enhancement: remove unnecessary proto from the sdk and add compdb suport #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbpcode
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: wangbaiping/wbpcode <[email protected]>
wbpcode
force-pushed
the
dev-clean-up
branch
from
2b4280b to
7916640
Compare
Signed-off-by: wangbaiping/wbpcode <[email protected]>
wbpcode
changed the title
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
wbpcode
force-pushed
the
dev-clean-up
branch
from
5b457bf to
6aab191
Compare
|
cc @mpwarres cc @PiotrSikora |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These protos should be part of specific plugin, but shouldn't be part of the SDK. This change make the SDK more thin and one day we may could make this a single/double file SDK.
To close #183