Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds not failing despite changelog and manifest version tests failing #57

Open
FLeven opened this issue Feb 19, 2022 · 1 comment
Open
Labels
bug Something isn't working waiting on reporter input Needs reporter input/response

Comments

@FLeven
Copy link

FLeven commented Feb 19, 2022

Expected Behavior

Build fails, if any Pester tests fails

Current Behavior

   [-] Changelog and manifest versions are the same 391ms (298ms|92ms)
    Expected 1.0.0.2, but got 1.0.0.0.
    at $changelogVersion -as [Version] | Should -Be ( $manifestData.Version -as [Version] ), C:\Users\jenkins\Agent\workspace\erShell-Modules_CCM-Build_master\tests\Manifest.tests.ps1:62
    at <ScriptBlock>, C:\Users\jenkins\Agent\workspace\erShell-Modules_CCM-Build_master\tests\Manifest.tests.ps1:62

Describing Git tagging
  [!] Is tagged with a valid version 80ms (0ms|80ms)
  [!] Matches manifest version 65ms (0ms|65ms)

Running tests from 'Meta.tests.ps1'
Describing Text files formatting
 Context File encoding
   [+] No text file uses Unicode/UTF-16 encoding 238ms (112ms|126ms)
 Context Indentations
   [+] No text file use tabs for indentations 250ms (129ms|121ms)
Tests completed in 36.97s
Tests Passed: 54, Failed: 1, Skipped: 2 NotRun: 0
...
Finished: SUCCESS

Possible Solution

Steps to Reproduce (for bugs)

  1. Change Manifest version
  2. Skip adding new version to changelog
  3. build

Context

I build my module in jenkins, saw the error, but my build never failed

Your Environment

Jenkins Agent Container (Windows Docker EE)
Powershell 5.1

@devblackops devblackops added the bug Something isn't working label Sep 16, 2022
@HeyItsGilbert
Copy link
Member

How are you calling your builds? See the docs on how to ensure your build fails: https://psake.dev/docs/tutorial-basics/how-to-fail-a-build

@HeyItsGilbert HeyItsGilbert added the waiting on reporter input Needs reporter input/response label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on reporter input Needs reporter input/response
Projects
None yet
Development

No branches or pull requests

3 participants