WIP# 4

Author: Vladislav Yashkov

python/tests/test_connection.py

@@ -9,7 +9,6 @@
     ConnectionExecuteError,
     TransactionExecuteError,
 )
-from tests.helpers import count_rows_in_test_table
 
 from tests.helpers import count_rows_in_test_table
 

python/tests/test_cursor.py

@@ -168,8 +168,7 @@ async def test_cursor_as_async_manager(
         querystring=f"SELECT * FROM {table_name}",
         fetch_number=fetch_number,
     ) as cursor:
-        async for result in cursor:
-            all_results.append(result)
+        all_results.extend([result async for result in cursor])
 
     assert len(all_results) == expected_num_results
 

python/tests/test_transaction.py

@@ -16,7 +16,6 @@
     TransactionExecuteError,
     TransactionSavepointError,
 )
-from tests.helpers import count_rows_in_test_table
 
 from tests.helpers import count_rows_in_test_table
 

src/driver/cursor.rs

@@ -13,7 +13,7 @@ use crate::{
 };
 
 /// Additional implementation for the `Object` type.
-#[allow(clippy::ref_option)]
+#[allow(clippy::ref_option_ref)]
 trait CursorObjectTrait {
     async fn cursor_start(
         &self,
@@ -34,7 +34,7 @@ impl CursorObjectTrait for Object {
     ///
     /// # Errors
     /// May return Err Result if cannot execute querystring.
-    #[allow(clippy::ref_option)]
+    #[allow(clippy::ref_option_ref)]
     async fn cursor_start(
         &self,
         cursor_name: &str,

src/query_result.rs

@@ -10,7 +10,7 @@ use crate::{exceptions::rust_errors::RustPSQLDriverPyResult, value_converter::po
 /// May return Err Result if can not convert
 /// postgres type to python or set new key-value pair
 /// in python dict.
-#[allow(clippy::ref_option)]
+#[allow(clippy::ref_option_ref)]
 fn row_to_dict<'a>(
     py: Python<'a>,
     postgres_row: &'a Row,