Bugfix: Convert async fs operation to sync so it doesnt fail in newer… (#175)

renarsvilnis · pstadler · commit 2f23db54016a · 2018-08-18T10:41:43.000+02:00
* Bugfix: Convert async fs operation to sync so it doesnt fail in newer node.js versions

* Fix unlinkSync in tests
diff --git a/lib/transport/shell.js b/lib/transport/shell.js
@@ -131,7 +131,7 @@ Shell.prototype.transfer = function(files, remoteDir, options) {
 
   Future.wait(tasks);
 
-  fs.unlink(tmpFile);
+  fs.unlinkSync(tmpFile);
 
   return results;
 };
diff --git a/test/test.transport.shell.js b/test/test.transport.shell.js
@@ -33,7 +33,7 @@ describe('transport/shell', function() {
       writeTempFile: WRITE_TEMP_FILE_STUB
     },
     'fs': {
-      unlink: function() {}
+      unlinkSync: function() {}
     }
   };
 

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ describe('transport/shell', function() {`
`33`	`33`	`writeTempFile: WRITE_TEMP_FILE_STUB`
`34`	`34`	`},`
`35`	`35`	`'fs': {`
`36`		`- unlink: function() {}`
	`36`	`+ unlinkSync: function() {}`
`37`	`37`	`}`
`38`	`38`	`};`
`39`	`39`