Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umsetzung eines Popover-Button #7388

Open
deleonio opened this issue Feb 17, 2025 · 1 comment · Fixed by #7391 or #7414
Open

Umsetzung eines Popover-Button #7388

deleonio opened this issue Feb 17, 2025 · 1 comment · Fixed by #7391 or #7414
Assignees
@sdvg
Labels
a11y-retest doc Improvements or additions to documentation v2 v3 Here are issues that need to be resolved for version 3.

Comments

@deleonio
Copy link
Contributor

deleonio commented Feb 17, 2025 •
edited
Loading

Hi @sdvg, lass uns das Thema besprechen. Wir möchten das einzelnen Dropdown haben. Mit Popover. Das wäre ein Clone vom Spit-Button nur eben ein Schalter.

Es sollen alle Props vom Button funktionieren.

Hier die Lösungsskizze: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/popover

Nice2Have: Können wir prüfen, ob wir die Tooltip-Ausrichtung wiederverwenden?!
@deleonio deleonio moved this to 📄 Ready in KoliBri Board Feb 17, 2025
@deleonio deleonio added v2 v3 Here are issues that need to be resolved for version 3. doc Improvements or additions to documentation a11y-retest labels Feb 17, 2025
@sdvg sdvg moved this from 📄 Ready to 🏗 In progress in KoliBri Board Feb 17, 2025
sdvg added a commit that referenced this issue Feb 18, 2025
@sdvg
Button wc: Support _popoverTarget
9bef5ec 
Refs: #7388
sdvg added a commit that referenced this issue Feb 18, 2025
@sdvg
Remove stray file from itzbund theme
c9c1bf7 
Refs: #7388
sdvg added a commit that referenced this issue Feb 18, 2025
@sdvg
Add component KolPopoverButton
0d2d84d 
Refs: #7388
@sdvg sdvg mentioned this issue Feb 18, 2025
Merged
5 tasks
@sdvg sdvg linked a pull request Feb 18, 2025 that will close this issue
Add component KolPopoverButton #7391
Merged
5 tasks
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Replace declarative with imperative popover API to fix focus/tabbing …
2e38421 
…issues in Chrome and Safari

Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Improve samples
9484ed1 
Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Fix button toggle behaviour
b26e97a 
Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Fix the occasional flicker when popover position is set
ff82e22 
Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Remove button popovertarget property
4e5fdca 
Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Add basic unit tests
e521b4c 
Refs: #7388
sdvg added a commit that referenced this issue Feb 20, 2025
@sdvg
Add E2E tests
a5bd4ab 
Refs: #7388
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in KoliBri Board Feb 24, 2025
@laske185
Copy link
Contributor

laske185 commented Feb 24, 2025 •
edited
Loading

Für Version 2 umgesetzt.

@laske185 laske185 reopened this Feb 24, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in KoliBri Board Feb 24, 2025
sdvg added a commit that referenced this issue Feb 25, 2025
@sdvg
Add KolPopoverButton component and theme styles
966312d 
Refs: #7388
@sdvg sdvg mentioned this issue Feb 25, 2025
Merged
5 tasks
@sdvg sdvg linked a pull request Feb 25, 2025 that will close this issue
Add KolPopoverButton component and theme styles #7414
Merged
5 tasks
sdvg added a commit that referenced this issue Feb 25, 2025
@sdvg
Update snapshot
d376570 
Refs: #7388
@sdvg sdvg moved this from 🏗 In progress to 🔍 Review in KoliBri Board Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdvg sdvg

Labels
a11y-retest doc Improvements or additions to documentation v2 v3 Here are issues that need to be resolved for version 3.
Projects
KoliBri Board
Status: 🔍 Review
Milestone
No milestone
3 participants
@sdvg @deleonio @laske185