Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9.1.1.1a - input-color: Alternativtexte für Bedienelemente #7164

Closed
Roman-Use opened this issue Dec 6, 2024 · 3 comments · Fixed by #7446
Closed

9.1.1.1a - input-color: Alternativtexte für Bedienelemente #7164

Roman-Use opened this issue Dec 6, 2024 · 3 comments · Fixed by #7446
Assignees
@anicyne
Labels
a11y-refine v3 Here are issues that need to be resolved for version 3.

Comments

@Roman-Use
Copy link

Link to the code that reproduces this issue:
Kolibri Version 2.1.5

Which browser or operating system do you used to test KoliBri?
Chrome

How to reproduce issue?
Den Colorpicker von "Color with error" öffnen. Mit der Tab-Taste bei geöffnetem Screenreader durch die interaktiven Elementen navigieren. Dies trifft für "Color with error" sowohl im fieldset "Color", als auch "Color (hideLabel)" auf.

Current vs. Expected:
Aktuelles Verhalten: Jeder der interaktiven Bedienelemente wird vom Screenreader NVDA als undefined vorgelesen (siehe Screenshot2).
Erwartetes Verhalten: Jedes interaktive Bedienelement wird von Screenreader NVDA mit den entsprechenden Beschriftungen vorgelesen. Beispielsweise können die Beschriftungen der anderen Colorpicker-Elemente übernommen werden (siehe Screenshot3).

Screenshot1:
2024-12-05_13h46_17

Screenshot2:
2024-12-05_14h25_29

Screenshot3:
2024-12-05_14h33_45
@deleonio
Copy link
Contributor

deleonio commented Dec 6, 2024

Hi @Roman-Use,

wir werden dieses Problem nicht mit Web lösen können. Es ist die Verantwortung der Browser- und OS-Hersteller das zu erledigen.

Link:https://public-ui.github.io/docs/concepts/known-issues

Wir werden das aber Dank Sir dokumentieren.

  • Known Issue erstellen und ein StackBlitz Sample für späteres regelmäßiges Nachprüfen

@deleonio deleonio moved this to 🗂️ Backlog in KoliBri Board Dec 6, 2024
@deleonio deleonio added a11y-refine v3 Here are issues that need to be resolved for version 3. labels Dec 6, 2024
@Roman-Use Roman-Use mentioned this issue Dec 19, 2024
Closed
@laske185
Copy link
Contributor

Lösungsansatz

  • Umsetzung analog Range
  • Neben color-input auch ein text-input, um die Farbe als hex-wert angeben zu können.
  • Input-color ist aria-hidden

Image

@laske185 laske185 moved this from 🗂️ Backlog to 📄 Ready in KoliBri Board Feb 26, 2025
@anicyne anicyne assigned anicyne and unassigned anicyne Mar 4, 2025
@anicyne anicyne moved this from 📄 Ready to 🏗 In progress in KoliBri Board Mar 6, 2025
anicyne added a commit that referenced this issue Mar 7, 2025
@anicyne
Add text input for hex value to kol-input-color
2e99c31 
Refs: #7164
@anicyne anicyne mentioned this issue Mar 7, 2025
Merged
5 tasks
@anicyne anicyne linked a pull request Mar 7, 2025 that will close this issue
Add text input for hex value to kol-input-color #7446
Merged
5 tasks
publicuibot bot pushed a commit that referenced this issue Mar 7, 2025
@anicyne @publicuibot
Update all snapshots$
4d87a97 
$
Refs: #7164
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 7, 2025
@anicyne anicyne moved this from 🔍 Review to 🏗 In progress in KoliBri Board Mar 10, 2025
anicyne added a commit that referenced this issue Mar 10, 2025
@anicyne
Add E2E test
79bbde3 
Refs: #7164
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 10, 2025
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Mar 12, 2025
@deleonio
Copy link
Contributor

Ergänzungen am PR: #7446 (comment)

anicyne added a commit that referenced this issue Mar 12, 2025
@anicyne
Fix input-color
3cdf1bf 
Refs: #7164
publicuibot bot pushed a commit that referenced this issue Mar 12, 2025
@anicyne @publicuibot
Update all snapshots$
c0263ac 
$
Refs: #7164
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 12, 2025
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anicyne anicyne

Labels
a11y-refine v3 Here are issues that need to be resolved for version 3.
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add text input for hex value to kol-input-color public-ui/kolibri
4 participants
@deleonio @laske185 @anicyne @Roman-Use