Skip to content

Commit bf7cf82

Browse files
crimsonredcrimsonred
authored
Merge pull request #14 from pubnub/CE-3278-DeleteMessagesFix
delete messages fix
2 parents 7b2492e + dd5e0d1 commit bf7cf82

29 files changed

+427
-170
lines changed

‎.pubnub.yml

Lines changed: 59 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,81 +1,88 @@
11
---
22
changelog:
3-
-
3+
-
4+
changes:
5+
-
6+
text: "Delete Messages Fix"
7+
type: improvement
8+
date: "Aug 23, 18"
9+
version: v4.0.2
10+
-
411
changes:
512
-
613
text: "Integration tests fixes"
714
type: improvement
8-
date: Mar 8, 18
15+
date: "Mar 8, 18"
916
version: v4.0.1
10-
-
17+
-
1118
changes:
1219
-
1320
text: "Here Now Refresh"
1421
type: improvement
15-
date: Feb 28, 18
22+
date: "Feb 28, 18"
1623
version: v4.0-rc2
17-
-
24+
-
1825
changes:
1926
-
20-
text: "Cleanup"
27+
text: Cleanup
2128
type: improvement
22-
date: Jan 22, 18
29+
date: "Jan 22, 18"
2330
version: v4.0-beta6
24-
-
31+
-
2532
changes:
2633
-
2734
text: "Logging enhancements"
2835
type: improvement
29-
date: Jan 18, 18
30-
version: v4.0-beta5
31-
-
36+
date: "Jan 18, 18"
37+
version: v4.0-beta5
38+
-
3239
changes:
3340
-
34-
text: "Cleanup"
41+
text: Cleanup
3542
type: improvement
36-
date: Jan 16, 18
37-
version: v4.0-beta4
38-
-
43+
date: "Jan 16, 18"
44+
version: v4.0-beta4
45+
-
3946
changes:
4047
-
4148
text: "Windows Universal compatibility"
4249
type: improvement
43-
date: Jan 11, 18
44-
version: v4.0-beta3
45-
-
50+
date: "Jan 11, 18"
51+
version: v4.0-beta3
52+
-
4653
changes:
4754
-
4855
text: "Leave fixes"
4956
type: improvement
50-
date: Dec 26, 17
51-
version: v4.0-beta2
52-
-
57+
date: "Dec 26, 17"
58+
version: v4.0-beta2
59+
-
5360
changes:
5461
-
5562
text: "All new PubNub Unity SDK"
5663
type: improvement
57-
date: Dec 11, 17
64+
date: "Dec 11, 17"
5865
version: v4.0-beta1
5966
-
6067
changes:
6168
-
6269
text: "Presence delta intervals"
6370
type: improvement
64-
date: Dec 18, 17
71+
date: "Dec 18, 17"
6572
version: v3.7.10
6673
-
6774
changes:
6875
-
6976
text: "Unity UWP compatibility"
7077
type: improvement
71-
date: Aug 8, 17
78+
date: "Aug 8, 17"
7279
version: v3.7.9
7380
-
7481
changes:
7582
-
7683
text: "Presence delta intervals"
7784
type: improvement
78-
date: Mar 31, 17
85+
date: "Mar 31, 17"
7986
version: v3.7.8
8087
-
8188
changes:
@@ -85,21 +92,21 @@ changelog:
8592
-
8693
text: "Prefix UUID with 'pn-'"
8794
type: improvement
88-
date: Feb 20, 17
95+
date: "Feb 20, 17"
8996
version: v3.7.7
9097
-
9198
changes:
9299
-
93100
text: "Fixed user state issue for other UUID"
94101
type: bug
95-
date: Jan 12, 17
102+
date: "Jan 12, 17"
96103
version: v3.7.6.2
97104
-
98105
changes:
99106
-
100107
text: "Changed origin to ps.pndsn.com"
101108
type: feature
102-
date: Dec 21, 16
109+
date: "Dec 21, 16"
103110
version: v3.7.6.1
104111
-
105112
changes:
@@ -109,7 +116,7 @@ changelog:
109116
-
110117
text: "Find out which UUID sent the message (only avialable when debug symbol `PUBNUB_PS_V2_RESPONSE` is used)."
111118
type: feature
112-
date: Dec 9, 16
119+
date: "Dec 9, 16"
113120
version: v3.7.6
114121
-
115122
changes:
@@ -129,7 +136,7 @@ changelog:
129136
-
130137
text: "Added a debug symbol `PUBNUB_PS_V2_RESPONSE` to enable v4 subscribe"
131138
type: feature
132-
date: Sep 24, 16
139+
date: "Sep 24, 16"
133140
version: v3.7.4
134141
-
135142
changes:
@@ -155,7 +162,7 @@ changelog:
155162
-
156163
text: "Code optimizations"
157164
type: improvement
158-
date: Aug 2, 16
165+
date: "Aug 2, 16"
159166
version: v3.7.2
160167
-
161168
changes:
@@ -165,7 +172,7 @@ changelog:
165172
-
166173
text: "For iOS if the value of NonSubscribeTimeout and SubscribeTimeout is greater than 59 secs, the SDK will force the value to be 59 secs."
167174
type: improvement
168-
date: Jun 21, 16
175+
date: "Jun 21, 16"
169176
version: v3.6.9.1
170177
-
171178
changes:
@@ -177,9 +184,9 @@ changelog:
177184
type: improvement
178185
-
179186
text: |
180-
`Logging: In addition to setting the variables PubnubLogLevel = LoggingMethod.Level.Info and PubnubErrorLevel = PubnubErrorFilter.Level.Info you also need to add a "define symbol": ENABLE_PUBNUB_LOGGING for each of the platform you want to enable logging.
187+
`Logging: In addition to setting the variables PubnubLogLevel = LoggingMethod.Level.Info and PubnubErrorLevel = PubnubErrorFilter.Level.Info you also need to add a "define symbol": ENABLE_PUBNUB_LOGGING for each of the platform you want to enable logging.
181188
182-
This setting is available in the Unity Editor: File-> Build Settings -> Player Settings -> Other Settings -> Configuration -> Scripting define symbols.
189+
This setting is available in the Unity Editor: File-> Build Settings -> Player Settings -> Other Settings -> Configuration -> Scripting define symbols.
183190
After you type ENABLE_PUBNUB_LOGGING in it do remember to press return with the focus still in the text box or your setting will not be saved.
184191
`
185192
type: improvement
@@ -248,6 +255,8 @@ features:
248255
- CHANNEL-GROUPS-REMOVE-CHANNELS
249256
- CHANNEL-GROUPS-REMOVE-GROUPS
250257
- CHANNEL-GROUPS-LIST-CHANNELS-IN-GROUP
258+
others:
259+
- TELEMETRY
251260
presence:
252261
- PRESENCE-HERE-NOW
253262
- PRESENCE-WHERE-NOW
@@ -287,24 +296,22 @@ features:
287296
- REQUEST-MESSAGE-COUNT-EXCEEDED
288297
time:
289298
- TIME-TIME
290-
others:
291-
- TELEMETRY
292-
supported-platforms:
293-
-
294-
version: PubNub Unity SDK
295-
platforms:
296-
- iOS player, will require iOS 7.0 or higher.
297-
- Android, OS 2.3.1 or later; ARMv7 (Cortex) CPU with NEON support or Atom CPU; OpenGL ES 2.0 or later.
298-
- Windows Phone, 8.1 or later.
299-
- Windows Store Apps, 8.1 or later.
300-
- WebGL, Any recent desktop version of Firefox, Chrome, Edge or Safari.
301-
- Windows 7+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
302-
- Ubuntu 12.04+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
303-
- Mac OS X 10.8+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support.
304-
editors:
305-
- Unity 5.5.1
306-
- Unity 2017.3.0f3
307299
name: unity
308300
schema: 1
309301
scm: github.com/pubnub/unity
310-
version: "v4.0.1"
302+
supported-platforms:
303+
-
304+
editors:
305+
- "Unity 5.5.1"
306+
- "Unity 2017.3.0f3"
307+
platforms:
308+
- "iOS player, will require iOS 7.0 or higher."
309+
- "Android, OS 2.3.1 or later; ARMv7 (Cortex) CPU with NEON support or Atom CPU; OpenGL ES 2.0 or later."
310+
- "Windows Phone, 8.1 or later."
311+
- "Windows Store Apps, 8.1 or later."
312+
- "WebGL, Any recent desktop version of Firefox, Chrome, Edge or Safari."
313+
- "Windows 7+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
314+
- "Ubuntu 12.04+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
315+
- "Mac OS X 10.8+, with Graphics card DX9 (shader model 3.0) or DX11 with feature level 9.3 capabilities; and CPU SSE2 instruction set support."
316+
version: "PubNub Unity SDK"
317+
version: v4.0.2

‎PubNubUnity/Assets/Builders/History/DeleteMessagesRequestBuilder.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ public void Async(Action<PNDeleteMessagesResult, PNStatus> callback)
3939
return;
4040
}
4141

42+
if(string.IsNullOrEmpty(this.PubNubInstance.PNConfig.SecretKey)){
43+
PNStatus pnStatus = base.CreateErrorResponseFromMessage("SecretKey is required", null, PNStatusCategory.PNBadRequestCategory);
44+
Callback(null, pnStatus);
45+
46+
return;
47+
}
48+
4249
base.Async(this);
4350
}
4451

0 commit comments

Comments
 (0)