Skip to content

Duplicate crd packages #51

Description

@keithharvey

Context

Hey, great work on crd2pulumi. One issue I just hit on trying to pulumi up after I imported my second crd2pulumi converted library was that both node packages had the default nodeName of "crd".

This resulted in an "incorrect semver" error because it tried to compare the version of the first library (which was an empty string by default) and the newly converted library (which also was an empty string) and node semver choked. Giving them both unique nodeName parameters cleared it up.

Possible solutions

  • Make at least 1 language target required. So users of crd2pulumi must specify nodejs and nodejsPath and nodeName.
  • attach a guid to the default "crd"

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/codegenAffects quality or correctness of generated codeimpact/usabilitySomething that impacts users' ability to use the product easily and intuitivelykind/enhancementImprovements or new features

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions