Commit 58e3764
committed
seo: harden backfill-openapi-lastmod.js arg parsing; clarify digest verification scope
Addresses two low-confidence findings from pre-merge review on d48c756:
- --cache-dir/--seed-ledger now reject a missing value instead of silently
setting undefined (which surfaced later as an opaque path.join TypeError,
or worse, a silent fallback to git history for --seed-ledger).
- Clarified in code comments and the log line that only the CDX API's
reported digest is checked against the recorded value, not the fetched
body -- Wayback's digest is computed over the raw compressed bytes as
captured, which fetch() transparently decompresses, so a body-level
re-hash was attempted and confirmed to always mismatch on legitimate
content. Not worth a broken check for a one-time, human-reviewed script
whose only output is a committed diff.1 parent d48c756 commit 58e3764
1 file changed
Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
132 | 142 | | |
133 | 143 | | |
134 | 144 | | |
| |||
276 | 286 | | |
277 | 287 | | |
278 | 288 | | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
279 | 297 | | |
280 | 298 | | |
281 | 299 | | |
282 | 300 | | |
283 | 301 | | |
284 | | - | |
285 | | - | |
| 302 | + | |
| 303 | + | |
286 | 304 | | |
287 | 305 | | |
288 | 306 | | |
| |||
0 commit comments