Commit f606c01
Make the nightly claims re-verify check facts, not itself (#20851)
* Make the nightly claims re-verify check facts, not itself
The lane's first two live sweeps (Aug 11-12) checked 50 volatile entities and
found 0 stale. Both halves of that result were misleading, in the two ways
the workflow header had flagged as worth watching.
Verdicts sourced from our own docs:
22 of the 35 `verified` verdicts cited nothing but Pulumi's own published
content — 16 of them the published copy of the very page making the claim
("verified high" for content/docs/iac/get-started/aws/modify-program.md,
source https://www.pulumi.com/docs/iac/get-started/aws/modify-program/).
www.pulumi.com is this repo rendered, so those checks confirmed each page
against itself: they can never go stale, and a `contradicted` from the same
place would be equally meaningless. The worst case restated a marketing
figure ("5-10X improvements") as verified by quoting itself.
`source_is_own_corpus` now demotes any decided verdict whose every cited
source is a www.pulumi.com URL or a `content/` file to `unverifiable` —
reported, never counted fresh, never written as a stale marker. Positive
evidence only: a source naming nothing identifiable (no URL, no path) is
left alone, since unrecognized is not the same as circular. Replayed over
both nights' reports this demotes 22 of 35, leaving 13 real verifications
against AWS docs, pulumi/pulumi source, and the policy-pack data files.
Entities that were never volatile:
48 of the 50 were typed `numerical`, which entity_key.py made volatile
unconditionally, so counts of a page's own example output rode along —
"this tutorial takes 15 minutes", "the example update creates 3 resources".
Those figures are properties of the prose and can only change when the page
changes; 8 came back `not-a-claim` from the verifier saying so. They are now
excluded from `volatile` (still keyed, still indexed, still checked whenever
the page is reviewed).
reverify-claims.py re-derives the flag through `entity_key.is_volatile`
instead of trusting what each snapshot stored, so the narrower rule applies
to the whole index the night it ships rather than page by page as each page
is re-reviewed. It falls back to the stored flag if the module can't load.
Also adds the report artifact the Slack summary has always pointed at but the
workflow never uploaded. It matters more than it sounds: Actions masks every
occurrence of the org name, so source URLs in the run log read `www.***.com`,
which is exactly the field this change turns on.
The two fixes are complementary and deliberately partial. Narrowing the
classifier shrinks the set; the source rule stops the remainder from being
recorded as confirmed on circular evidence. Neither prevents the verifier from
reaching for the site in the first place — doing that means touching
verify-claims.py's prompt, which the pre-merge review lane shares, so it wants
its own change.
`make lint`, `make test-review-pipeline` (21 suites) green. The new
assertions in both suites were negative-tested: they go red against the
pre-fix code and name the specific behavior that regressed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* Address both low-confidence review findings
Health-lane interaction with demotion (1 parent d7fe8b9 commit f606c01
4 files changed
Lines changed: 247 additions & 21 deletions
File tree
- .claude/commands/docs-review/scripts
- .github/workflows
- scripts/content-review
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
64 | 89 | | |
65 | 90 | | |
66 | 91 | | |
| |||
147 | 172 | | |
148 | 173 | | |
149 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
150 | 178 | | |
151 | 179 | | |
152 | 180 | | |
| |||
170 | 198 | | |
171 | 199 | | |
172 | 200 | | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
173 | 212 | | |
174 | 213 | | |
175 | 214 | | |
| |||
234 | 273 | | |
235 | 274 | | |
236 | 275 | | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
237 | 310 | | |
238 | 311 | | |
239 | 312 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
37 | 46 | | |
38 | 47 | | |
39 | 48 | | |
| |||
179 | 188 | | |
180 | 189 | | |
181 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
182 | 203 | | |
183 | 204 | | |
184 | 205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
37 | 43 | | |
38 | 44 | | |
39 | 45 | | |
| |||
53 | 59 | | |
54 | 60 | | |
55 | 61 | | |
| 62 | + | |
56 | 63 | | |
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
60 | 67 | | |
61 | 68 | | |
62 | 69 | | |
| 70 | + | |
63 | 71 | | |
64 | 72 | | |
65 | 73 | | |
66 | 74 | | |
67 | 75 | | |
68 | 76 | | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
69 | 80 | | |
70 | 81 | | |
71 | 82 | | |
| |||
86 | 97 | | |
87 | 98 | | |
88 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
89 | 149 | | |
90 | 150 | | |
91 | 151 | | |
| |||
105 | 165 | | |
106 | 166 | | |
107 | 167 | | |
108 | | - | |
| 168 | + | |
109 | 169 | | |
110 | 170 | | |
111 | 171 | | |
112 | 172 | | |
113 | | - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
114 | 178 | | |
115 | 179 | | |
116 | 180 | | |
117 | | - | |
| 181 | + | |
118 | 182 | | |
119 | 183 | | |
120 | 184 | | |
| |||
239 | 303 | | |
240 | 304 | | |
241 | 305 | | |
242 | | - | |
| 306 | + | |
| 307 | + | |
243 | 308 | | |
244 | 309 | | |
245 | 310 | | |
| |||
258 | 323 | | |
259 | 324 | | |
260 | 325 | | |
261 | | - | |
| 326 | + | |
262 | 327 | | |
263 | 328 | | |
264 | 329 | | |
265 | 330 | | |
266 | 331 | | |
267 | | - | |
268 | | - | |
269 | | - | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
270 | 337 | | |
271 | 338 | | |
272 | 339 | | |
| |||
275 | 342 | | |
276 | 343 | | |
277 | 344 | | |
278 | | - | |
| 345 | + | |
279 | 346 | | |
280 | 347 | | |
281 | 348 | | |
| |||
299 | 366 | | |
300 | 367 | | |
301 | 368 | | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
302 | 373 | | |
303 | 374 | | |
304 | | - | |
| 375 | + | |
| 376 | + | |
305 | 377 | | |
306 | 378 | | |
307 | 379 | | |
| |||
320 | 392 | | |
321 | 393 | | |
322 | 394 | | |
| 395 | + | |
323 | 396 | | |
324 | 397 | | |
325 | 398 | | |
| |||
371 | 444 | | |
372 | 445 | | |
373 | 446 | | |
| 447 | + | |
374 | 448 | | |
375 | 449 | | |
376 | 450 | | |
377 | 451 | | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
378 | 484 | | |
379 | 485 | | |
380 | 486 | | |
| |||
0 commit comments