Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 - #3131
Conversation
…2007d6d268b65b739ffb5ebf8c1e76
Review Verdict: ApprovedMechanical, uniform SDK regeneration confined entirely to generated/vendored paths (sdk/, schema.json, metadata.json, aws-cloudformation-schema/); confirmed the two flagged breaking changes trace to legitimate upstream CFN schema updates rather than a codegen defect, and independently verified the Go/.NET/Node.js/Python SDKs all build cleanly. CI is green on every completed check with no failures. Automated low-risk assessment, not a human review. View session · Was this review helpful? Yes · No |
Does the PR have any schema changes?Generated by schema-tools v0.8.1. Found 2 breaking changes: Resources
New resources:
New functions:
New types: 184 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3131 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 58 58
Lines 8157 8157
=======================================
Hits 4929 4929
Misses 2870 2870
Partials 358 358 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Reviewed this automated SDK regeneration PR (bump to aws-cloudformation-user-guide @ 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76).
Scope verification: confirmed the entire 1028-file diff is confined to generated/vendored artifacts per this repo's AGENTS.md — sdk/{nodejs,python,dotnet,go}/**, provider/cmd/pulumi-resource-aws-native/{schema,metadata}.json, provider/cmd/pulumi-gen-aws-native/supported-types.txt, aws-cloudformation-schema/**, meta/.botocore.version, and reports/missedAutonaming.json. No hand-written files under provider/pkg/** or examples/** were touched, and no forbidden files (.github/workflows/**, .config/mise.toml) were modified.
Breaking changes: the schema-diff bot flagged two required-property relaxations (bedrockagentcore:PaymentConnector.credentialProviderConfigurations, bedrockagentcore:Runtime.networkConfiguration). Traced both directly to the upstream CloudFormation resource schema changes in this diff (new ProvisionMode/QUICK_CREATE flow for PaymentConnector, and NetworkConfiguration removed from the upstream required list for Runtime) — these are legitimate upstream schema changes carried through by the regeneration, not a codegen defect.
Specialist passes (correctness, security, AGENTS.md compliance, tests) all returned no findings:
- Correctness: validated schema.json/metadata.json integrity (no new dangling refs), and confirmed the Go, .NET, Node.js, and Python SDKs all build/typecheck/import cleanly including the newly added resource packages (agentregistry, bedrockagentcore, deadline, personalize, translate, etc.).
- Security: no hardcoded secrets, no new unmarked-secret regressions beyond this repo's existing (pre-existing) convention for credential-like resource properties.
- AGENTS.md compliance: no hand-edits to generated/forbidden paths; all changed files match expected generation-pipeline outputs.
- Tests: no gap relative to this repo's established pattern for this PR category — prior "Automated SDK generation" PRs (#3122, #3107) followed the same pure-regeneration shape and relied on the same CI build/typecheck jobs plus generic schema-driven checks (e.g.
TestNoUnexpectedTagsShapes) rather than per-resource example tests.
CI: all checks that have completed are green (lint, prerequisites, build_sdks for java/nodejs/python/dotnet, codecov, warn_codegen); build_sdks (go) was still in progress at review time with no failures observed anywhere.
This matches the established, repeatedly-merged pattern for this PR class (precedent: #3122, #3114, #3107, #3084, #3073), so I'm treating it as a low-risk, uniform, mechanical regeneration.
|
This PR has been shipped in release v1.76.0. |
Automated PR