Skip to content

Commit 03e9f89

Browse files
committed
updates based on eon review
1 parent 1509358 commit 03e9f89

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

examples/examples_yaml_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ func validateEcrCreds(t *testing.T, pulumiTest *pulumitest.PulumiTest, result au
227227
userName, ok := result.Outputs["userName"].Value.(string)
228228
require.Truef(t, ok, "expected decoded userName output to be a string; got %s", userNameValue)
229229
assert.Equal(t, "AWS", userName)
230+
assert.False(t, result.Outputs["userName"].Secret, "expected decoded userName output to remain non-secret")
230231

231232
password, ok := result.Outputs["password"].Value.(string)
232233
require.True(t, ok, "expected decoded password output to be a string")
@@ -258,7 +259,7 @@ func validateEcrCreds(t *testing.T, pulumiTest *pulumitest.PulumiTest, result au
258259

259260
func TestAccEcrCredentials(t *testing.T) {
260261
test := pulumitest.NewPulumiTest(t,
261-
filepath.Join(getCwd(t), "ecr-credentials"),
262+
filepath.Join(getCwd(t), "test-programs", "ecr-credentials"),
262263
opttest.SkipInstall(),
263264
opttest.LocalProviderPath("aws", filepath.Join(getCwd(t), "..", "bin")),
264265
)
@@ -270,7 +271,7 @@ func TestAccEcrCredentials(t *testing.T) {
270271
}
271272

272273
func TestEcrCredentialsUpgrade(t *testing.T) {
273-
test, _ := testProviderUpgrade(t, filepath.Join(getCwd(t), "ecr-credentials"), &testProviderUpgradeOptions{
274+
test, _ := testProviderUpgrade(t, filepath.Join("test-programs", "ecr-credentials"), &testProviderUpgradeOptions{
274275
skipCache: true,
275276
skipDefaultPreviewTest: true,
276277
})
File renamed without changes.

provider/resources.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4897,6 +4897,7 @@ func providerFromMeta(
48974897
Omit: true,
48984898
},
48994899
"authorization_token": {
4900+
// Intentionally non-secret for v6 compatibility, even though it base64-encodes password.
49004901
Secret: new(false),
49014902
},
49024903
},

0 commit comments

Comments
 (0)