No docs found for aws_ecr_credentials/ecr.getCredentials()

[jkodroff]

aws_ecr_credentials is a custom data source in our fork of terraform-provider-aws, but it lacks docs. We need to add at least some rudimentary docs.

[jkodroff]

Registry page (missing most attribute descriptions): https://www.pulumi.com/registry/packages/aws/api-docs/ecr/getcredentials/

I think this is what it maps to in upstream, but maybe it's an overlay? https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ecr_authorization_token

[jkodroff]

@pulumi-eon Analyze this issue and let me know how hard the fix is.

[eon-pulumi]

Done

Summary

Difficulty: Low. This is a small, self-contained docs override — one provider file plus a test, no upstream patch or schema-shape changes.

Root cause

aws_ecr_credentials (ecr.getCredentials()) is not an upstream Terraform data source. It's a Pulumi-side shim over the upstream aws_ecr_authorization_token data source, created in addLegacyECRCredentialsDataSource (provider/resources.go:61) and kept for v6 backwards compatibility. Since it has no upstream doc file, provider/data_source_overrides.go set Docs: {AllowMissing: true}, which silences the missing-docs error and leaves the registry page empty. So your hunch was right — it maps to aws_ecr_authorization_token, but as a bridge shim rather than a normal upstream data source.

Fix (PR #6615)

Replaced AllowMissing: true with inline Markdown docs written to match the shim's actual schema. The shim differs from aws_ecr_authorization_token: registry_id is required and region is omitted — so I authored tailored docs rather than reusing the upstream doc verbatim (which would advertise a nonexistent region argument). The markdown uses standard TF-website structure and snake_case field names, which is what the bridge's docs parser matches against schema properties before translating to each target language.

Testing

• Provider package compiles; gofmt clean.
• Added TestECRCredentialsHasInlineDocs (passes) asserting the data source now ships non-empty inline docs and no longer relies on AllowMissing.

One caveat: I did not run a full make schema/SDK regeneration (it's a 15+ min build in this repo). The change is docs-only and the markdown mirrors the upstream ecr_authorization_token.html.markdown the pipeline already handles, so confidence is high, but the rendered registry page should be confirmed once CI regenerates the schema.

PR: #6615

Created:

• PR #6615

---

View session