Skip to content

Commit 4a88f88

Browse files
Makeshiftguineveresaengerclaude
authored
Allow pulumi.Output in EKS Addon configurationValues (#1632)
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes <!--Give us a brief description of what you've done and what it solves. --> Someone went through the effort of creating a stringify function and forgot to use it 😁 **Edit by @guineveresaenger:** To preserve ordering I took the author's suggestion and used `pulumi.jsonStringify`. This should fix up the PR enough to be mergeable. If a reviewer would like ordering-specific testing, we can do so; however this is a minor enough refactor that I do not think explicit test is warranted. --------- Co-authored-by: guineveresaenger <guinevere@pulumi.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent ef1a741 commit 4a88f88

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

nodejs/eks/addons/addon.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import { Cluster } from "../cluster";
2424
export interface AddonOptions
2525
extends Omit<aws.eks.AddonArgs, "resolveConflicts" | "clusterName" | "configurationValues"> {
2626
cluster: Cluster;
27-
configurationValues?: object;
27+
configurationValues?: pulumi.Input<object>;
2828
}
2929

3030
/**
@@ -37,17 +37,18 @@ export class Addon extends pulumi.ComponentResource {
3737
constructor(name: string, args: AddonOptions, opts?: pulumi.CustomResourceOptions) {
3838
const cluster = args.cluster;
3939

40-
super("eks:index:Addon", name, args, {
41-
...opts,
40+
super("eks:index:Addon", name, args, pulumi.mergeOptions(opts, {
4241
parent: cluster,
43-
});
42+
}));
4443

4544
const addon = new aws.eks.Addon(
4645
name,
4746
{
4847
...args,
4948
clusterName: cluster.core.cluster.name,
50-
configurationValues: JSON.stringify(args.configurationValues),
49+
configurationValues: args.configurationValues
50+
? pulumi.jsonStringify(args.configurationValues)
51+
: undefined,
5152
},
5253
{ parent: this, provider: opts?.provider },
5354
);

0 commit comments

Comments
 (0)