You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The read_ and parse_ iotools functions are largely redundant; read_ is a simple wrapper around parse_. It has been suggested to remove the parse_ functions and have read_ work with both file-like objects and filenames/URLs.
I think we should get rid of the parse functions which will significantly reduce duplicated documentation (if anything then make the parse functions private with little documentation).
Are we also going to add support for buffers to read_nsrdb_psm4? I recommend moving forward with this PR API as is and if you want to take that on before the next release then go for it.
Also need to edit the docstring returns sections if this function becomes private.
I am +1 to getting rid of parse_. There is some discussion back in #842 that may be of interest.
If we go ahead with this, we should start with the parse_ function in pvlib.iools.psm4, as it has not been included in a release yet and thus does not need a deprecation period.
The text was updated successfully, but these errors were encountered:
The
read_
andparse_
iotools functions are largely redundant;read_
is a simple wrapper aroundparse_
. It has been suggested to remove theparse_
functions and haveread_
work with both file-like objects and filenames/URLs.@AdamRJensen in #2326 (comment):
and @wholmgren in #2378 (comment):
I am +1 to getting rid of
parse_
. There is some discussion back in #842 that may be of interest.If we go ahead with this, we should start with the
parse_
function inpvlib.iools.psm4
, as it has not been included in a release yet and thus does not need a deprecation period.The text was updated successfully, but these errors were encountered: