Skip to content

Commit 2acb632

Browse files
Lucas-CCimon Lucas (LCM)
and
Cimon Lucas (LCM)
authored
Fix test_cat_subset_ensure_reduced_size() (#45)
Co-authored-by: Cimon Lucas (LCM) <[email protected]>
1 parent 1aefb3a commit 2acb632

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

tests/conftest.py

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ def run_cli(args):
3838
@pytest.fixture
3939
def two_pages_pdf_filepath(tmp_path):
4040
"A PDF with 2 pages, and a different image on each page"
41+
# Note: prior to v2.7.9, fpdf2 produced incorrect /Resources dicts for each page (cf. fpdf2 PR #1133),
42+
# leading to an "anormal" two_pages.pdf generated there, and for test_cat_subset_ensure_reduced_size() to fail.
4143
pdf = FPDF()
4244
pdf.add_page()
4345
pdf.image(RESOURCES_ROOT / "baleines.jpg")

tests/test_cat.py

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ def test_cat_subset_warn_on_missing_pages(capsys, tmp_path):
8787
assert "WARN" in captured.err
8888

8989

90-
@pytest.mark.xfail() # There is currently a bug there
9190
def test_cat_subset_ensure_reduced_size(tmp_path, two_pages_pdf_filepath):
9291
exit_code = run_cli(
9392
[

0 commit comments

Comments
 (0)