Pleasing ruff

Author: Lucas-C

pdfly/cat.py

@@ -42,7 +42,6 @@
 # All rights reserved. This software is available under a BSD license;
 # see https://github.com/py-pdf/pypdf/LICENSE
 
-
 import os
 import sys
 import traceback
@@ -59,9 +58,7 @@ def main(
     verbose: bool,
     inverted_page_selection: bool = False,
 ) -> None:
-    filename_page_ranges = parse_filepaths_and_pagerange_args(
-        filename, fn_pgrgs
-    )
+    filename_page_ranges = parse_filepaths_and_pagerange_args(filename, fn_pgrgs)
     if output:
         output_fh = open(output, "wb")
     else:
@@ -71,22 +68,16 @@ def main(
     writer = PdfWriter()
     in_fs = {}
     try:
-        for filename, page_range in filename_page_ranges:  # type: ignore
+        for filepath, page_range in filename_page_ranges:  # type: ignore
             if verbose:
-                print(filename, page_range, file=sys.stderr)
-            if filename not in in_fs:
-                in_fs[filename] = open(filename, "rb")
+                print(filepath, page_range, file=sys.stderr)
+            if filepath not in in_fs:
+                in_fs[filepath] = open(filepath, "rb")
 
-            reader = PdfReader(in_fs[filename])
+            reader = PdfReader(in_fs[filepath])
             num_pages = len(reader.pages)
             start, end, step = page_range.indices(num_pages)
-            if (
-                start < 0
-                or end < 0
-                or start >= num_pages
-                or end > num_pages
-                or start > end
-            ):
+            if start < 0 or end < 0 or start >= num_pages or end > num_pages or start > end:
                 print(
                     f"WARNING: Page range {page_range} is out of bounds",
                     file=sys.stderr,
@@ -111,17 +102,15 @@ def main(
     # Not closing the in_fs because this script exits now.
 
 
-def parse_filepaths_and_pagerange_args(
-    filename: Path, fn_pgrgs: List[str]
-) -> List[Tuple[Path, PageRange]]:
+def parse_filepaths_and_pagerange_args(filename: Path, fn_pgrgs: List[str]) -> List[Tuple[Path, PageRange]]:
     fn_pgrgs_l = list(fn_pgrgs)
     fn_pgrgs_l.insert(0, str(filename))
     filename_page_ranges, invalid_filepaths = [], []
-    for filename, page_range in parse_filename_page_ranges(fn_pgrgs_l):  # type: ignore
-        if Path(filename).is_file():
-            filename_page_ranges.append((filename, page_range))
+    for filepath, page_range in parse_filename_page_ranges(fn_pgrgs_l):  # type: ignore
+        if Path(filepath).is_file():
+            filename_page_ranges.append((filepath, page_range))
         else:
-            invalid_filepaths.append(str(filename))
+            invalid_filepaths.append(str(filepath))
     if invalid_filepaths:
         print(
             f"Invalid file path or page range provided: {' '.join(invalid_filepaths)}",

pdfly/cli.py

@@ -33,9 +33,7 @@ def version_callback(value: bool) -> None:
 
 entry_point = typer.Typer(
     add_completion=False,
-    help=(
-        "pdfly is a pure-python cli application for manipulating PDF files."
-    ),
+    help=("pdfly is a pure-python cli application for manipulating PDF files."),
     rich_markup_mode="rich",  # Allows to pretty-print commands documentation
 )
 
@@ -57,7 +55,7 @@ def extract_images(
             exists=True,
             resolve_path=True,
         ),
-    ]
+    ],
 ) -> None:
     pdfly.extract_images.main(pdf)
 
@@ -91,9 +89,7 @@ def cat(
     fn_pgrgs: List[str] = typer.Argument(  # noqa
         ..., help="filenames and/or page ranges"
     ),
-    verbose: bool = typer.Option(
-        False, help="show page ranges as they are being read"
-    ),
+    verbose: bool = typer.Option(False, help="show page ranges as they are being read"),
 ) -> None:
     pdfly.cat.main(filename, fn_pgrgs, output, verbose)
 
@@ -112,9 +108,7 @@ def rm(
     fn_pgrgs: List[str] = typer.Argument(  # noqa
         ..., help="filenames and/or page ranges"
     ),
-    verbose: bool = typer.Option(
-        False, help="show page ranges as they are being read"
-    ),
+    verbose: bool = typer.Option(False, help="show page ranges as they are being read"),
 ) -> None:
     pdfly.rm.main(filename, fn_pgrgs, output, verbose)
 
@@ -175,7 +169,7 @@ def extract_text(
             exists=True,
             resolve_path=True,
         ),
-    ]
+    ],
 ) -> None:
     """Extract text from a PDF file."""
     from pypdf import PdfReader
@@ -240,9 +234,7 @@ def update_offsets(
         "ISO-8859-1",
         help="Encoding used to read and write the files, e.g. UTF-8.",
     ),
-    verbose: bool = typer.Option(
-        False, help="Show progress while processing."
-    ),
+    verbose: bool = typer.Option(False, help="Show progress while processing."),
 ) -> None:
     pdfly.update_offsets.main(file_in, file_out, encoding, verbose)
 

pdfly/metadata.py

@@ -94,11 +94,7 @@ def main(pdf: Path, output: OutputOptions) -> None:
             creation_time=datetime.fromtimestamp(pdf_stat.st_ctime),
             modification_time=datetime.fromtimestamp(pdf_stat.st_mtime),
             access_time=datetime.fromtimestamp(pdf_stat.st_atime),
-            images=[
-                len(image.data)
-                for page in reader.pages
-                for image in page.images
-            ],
+            images=[len(image.data) for page in reader.pages for image in page.images],
         )
         if info is not None:
             meta.author = info.author
@@ -117,9 +113,7 @@ def main(pdf: Path, output: OutputOptions) -> None:
         from rich.table import Table
 
         table = Table(title="PDF Data")
-        table.add_column(
-            "Attribute", justify="right", style="cyan", no_wrap=True
-        )
+        table.add_column("Attribute", justify="right", style="cyan", no_wrap=True)
         table.add_column("Value", style="white")
 
         if meta.title:
@@ -149,21 +143,13 @@ def main(pdf: Path, output: OutputOptions) -> None:
                 emb, unemb = page._get_fonts()
                 embedded_fonts = embedded_fonts.union(set(emb))
                 unemedded_fonts = unemedded_fonts.union(set(unemb))
-            table.add_row(
-                "Fonts (unembedded)", ", ".join(sorted(unemedded_fonts))
-            )
-            table.add_row(
-                "Fonts (embedded)", ", ".join(sorted(embedded_fonts))
-            )
+            table.add_row("Fonts (unembedded)", ", ".join(sorted(unemedded_fonts)))
+            table.add_row("Fonts (embedded)", ", ".join(sorted(embedded_fonts)))
         table.add_row("Attachments", meta.attachments)
-        table.add_row(
-            "Images", f"{len(meta.images)} images ({sum(meta.images):,} bytes)"
-        )
+        table.add_row("Images", f"{len(meta.images)} images ({sum(meta.images):,} bytes)")
 
         enc_table = Table(title="Encryption information")
-        enc_table.add_column(
-            "Attribute", justify="right", style="cyan", no_wrap=True
-        )
+        enc_table.add_column("Attribute", justify="right", style="cyan", no_wrap=True)
         enc_table.add_column("Value", style="white")
         if meta.encryption:
             enc_table.add_row(
@@ -173,28 +159,18 @@ def main(pdf: Path, output: OutputOptions) -> None:
             enc_table.add_row("V value", str(meta.encryption.v_value))
 
         os_table = Table(title="Operating System Data")
-        os_table.add_column(
-            "Attribute", justify="right", style="cyan", no_wrap=True
-        )
+        os_table.add_column("Attribute", justify="right", style="cyan", no_wrap=True)
         os_table.add_column("Value", style="white")
         os_table.add_row("File Name", f"{pdf}")
         os_table.add_row("File Permissions", f"{meta.file_permissions}")
         os_table.add_row("File Size", f"{meta.file_size:,} bytes")
-        os_table.add_row(
-            "Creation Time", f"{meta.creation_time:%Y-%m-%d %H:%M:%S}"
-        )
-        os_table.add_row(
-            "Modification Time", f"{meta.modification_time:%Y-%m-%d %H:%M:%S}"
-        )
-        os_table.add_row(
-            "Access Time", f"{meta.access_time:%Y-%m-%d %H:%M:%S}"
-        )
+        os_table.add_row("Creation Time", f"{meta.creation_time:%Y-%m-%d %H:%M:%S}")
+        os_table.add_row("Modification Time", f"{meta.modification_time:%Y-%m-%d %H:%M:%S}")
+        os_table.add_row("Access Time", f"{meta.access_time:%Y-%m-%d %H:%M:%S}")
 
         console = Console()
         console.print(os_table)
         console.print(table)
         if meta.encryption:
             console.print(enc_table)
-        console.print(
-            "Use the 'pagemeta' subcommand to get details about a single page"
-        )
+        console.print("Use the 'pagemeta' subcommand to get details about a single page")

pdfly/pagemeta.py

@@ -38,9 +38,7 @@ def main(pdf: Path, page_index: int, output: OutputOptions) -> None:
         console = Console()
 
         table = Table(title=f"{pdf}, page index {page_index}")
-        table.add_column(
-            "Attribute", justify="right", style="cyan", no_wrap=True
-        )
+        table.add_column("Attribute", justify="right", style="cyan", no_wrap=True)
         table.add_column("Value", style="white")
 
         table.add_row(
@@ -57,9 +55,7 @@ def main(pdf: Path, page_index: int, output: OutputOptions) -> None:
         )
         table.add_row(
             "artbox",
-            f"{meta.artbox}: "
-            f"with={meta.artbox[2] - meta.artbox[0]} "
-            f"x height={meta.artbox[3] - meta.artbox[1]}",
+            f"{meta.artbox}: with={meta.artbox[2] - meta.artbox[0]} x height={meta.artbox[3] - meta.artbox[1]}",
         )
         table.add_row(
             "bleedbox",

pdfly/rm.py

@@ -44,7 +44,5 @@
 from pdfly.cat import main as cat_main
 
 
-def main(
-    filename: Path, fn_pgrgs: List[str], output: Path, verbose: bool
-) -> None:
+def main(filename: Path, fn_pgrgs: List[str], output: Path, verbose: bool) -> None:
     cat_main(filename, fn_pgrgs, output, verbose, inverted_page_selection=True)

pdfly/uncompress.py

@@ -33,9 +33,7 @@ def main(pdf: Path, output: Path) -> None:
     uncomp_size = output.stat().st_size
 
     print(f"Original Size  : {orig_size:,}")
-    print(
-        f"Uncompressed Size: {uncomp_size:,} ({(uncomp_size / orig_size) * 100:.1f}% of original)"
-    )
+    print(f"Uncompressed Size: {uncomp_size:,} ({(uncomp_size / orig_size) * 100:.1f}% of original)")
 
 
 def decompress_content_stream(content: IndirectObject) -> None:
@@ -47,6 +45,4 @@ def decompress_content_stream(content: IndirectObject) -> None:
             content.set_data(uncompressed_data)
             del content["/Filter"]
         except zlib.error as error:
-            print(
-                f"Some content stream with /FlateDecode failed to be decompressed: {error}"
-            )
+            print(f"Some content stream with /FlateDecode failed to be decompressed: {error}")