Fix test_cat_subset_ensure_reduced_size()

Cimon Lucas (LCM) · Cimon Lucas (LCM) · commit da39ed7e4ef9 · 2024-03-06T12:23:43.000+01:00
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -38,6 +38,8 @@ def run_cli(args):
 @pytest.fixture
 def two_pages_pdf_filepath(tmp_path):
     "A PDF with 2 pages, and a different image on each page"
+    # Note: prior to v2.7.9, fpdf2 produced incorrect /Resources dicts for each page (cf. fpdf2 PR #1133),
+    # leading to an "anormal" two_pages.pdf generated there, and for test_cat_subset_ensure_reduced_size() to fail.
     pdf = FPDF()
     pdf.add_page()
     pdf.image(RESOURCES_ROOT / "baleines.jpg")
diff --git a/tests/test_cat.py b/tests/test_cat.py
@@ -88,7 +88,6 @@ def test_cat_subset_warn_on_missing_pages(capsys, tmp_path):
     assert "WARN" in captured.out
 
 
-@pytest.mark.xfail()  # There is currently a bug there
 def test_cat_subset_ensure_reduced_size(tmp_path, two_pages_pdf_filepath):
     exit_code = run_cli(
         [

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,6 @@ def test_cat_subset_warn_on_missing_pages(capsys, tmp_path):`
`88`	`88`	`assert "WARN" in captured.out`
`89`	`89`
`90`	`90`
`91`		`-@pytest.mark.xfail() # There is currently a bug there`
`92`	`91`	`def test_cat_subset_ensure_reduced_size(tmp_path, two_pages_pdf_filepath):`
`93`	`92`	`exit_code = run_cli(`
`94`	`93`	`[`