Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Trying uv for faster CI #2852

Open
MartinThoma opened this issue Sep 15, 2024 · 2 comments
Open

MAINT: Trying uv for faster CI #2852

MartinThoma opened this issue Sep 15, 2024 · 2 comments
Labels
nf-ci Non-functional change: Continuous Integration

Comments

@MartinThoma
Copy link
Member

I want to try to use uv for pypdf in CI. The main reason is that I'm curious and I want to experiment. It might be that it's just not the right fit for pypdf :-)

Potential benefit

Speed: -17s (?)

Looking at https://github.com/py-pdf/pypdf/actions/runs/10873983099/job/30170754308 that could mean:

  • Additional time for installing UV, but hopefully equivalent to the 16s of updating pip
  • 17s for installing requirements ... ok, not too much 😅 But maybe we can reduce that

Modernized Tooling

  • uv is by the same people who created ruff. They are innovating a lot of the ecosystem.
  • pip-tools is super robust and does what it should. I'm happy with it. The tool feels mature.

However:

  • ci.in / dev.in / docs.in are non-standard
  • We use pyproject.toml with optional dependencies (including docs, but not including ci) already. So it might be a chance to simplify how we store dependencies.
@MartinThoma MartinThoma added the nf-ci Non-functional change: Continuous Integration label Sep 15, 2024
@stefan6419846
Copy link
Collaborator

Just my 2 cents: As long as we keep compatibility with pip, I am fine with it. ruff and uv (as most Rust applications) are a license compliance nightmare due to tons of dependencies to look into, thus I would like to avoid solely relying on them.

@MartinThoma
Copy link
Member Author

ruff and uv (as most Rust applications) are a license compliance nightmare due to tons of dependencies

Interesting! I wasn't aware of that

@py-pdf py-pdf deleted a comment Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-ci Non-functional change: Continuous Integration
Projects
None yet
Development

No branches or pull requests

2 participants