-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0 should not be pip installable for Python < 3.8 #2858
Comments
Thanks for the report. Yanking only works for complete releases. For now, I am not completely sure what the desired behavior is here. Personally, I would expect users to pin their requirements and to not use any Python version being EOL for more than one year any more (although we might have supported it). Before doing any yanking, let's wait for some further opinions from @pubpub-zz and @MartinThoma (who would have to do the yanking anyway). |
I'm in favor of "yanking" otherwise you force other project to manage themselves the dependencies of pypdf. |
I pinned |
I have no strong opinion. I'm OK ready to publish 5.0.1 this week-end if the change in pyproject.toml is OK. |
pypdf 5.0.0
is pip-installable for Python 3.7, but support for 3.7 is dropped as noted in the Changelog.Packages that require
pypdf > X
but don't specify<5
are subject to erroneously installingpypdf >= 5
when running on Python 3.7.Environment
Python 3.7, any OS
Code + PDF
This is a minimal, complete example that shows the issue:
Traceback
Same as listed above.
Suggested Fixes
pyproject.toml
to mark the minimum Python version as 3.8pypdf 5.0.0
distribution from PyPI for Python 3.7. I'm not sure if this is possible for a specific Python version - if not, it may still be best to yank the entire 5.0.0 release and re-publish it as 5.0.0.post1, or even 5.0.1.The text was updated successfully, but these errors were encountered: