Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate xr.cftime_range in favor of xr.date_range #9886

Closed
dcherian opened this issue Dec 13, 2024 · 3 comments · Fixed by #10024
Closed

Deprecate xr.cftime_range in favor of xr.date_range #9886

dcherian opened this issue Dec 13, 2024 · 3 comments · Fixed by #10024

Comments

@dcherian
Copy link
Contributor

dcherian commented Dec 13, 2024

What is your issue?

xr.date_range automatically chooses a return type based on calendar and can take use_cftime=True to always return CFTimeIndex, so I don't see why we need xr.cftime_range any more

@dcherian dcherian added needs triage Issue that has not been reviewed by xarray team member contrib-good-first-issue and removed needs triage Issue that has not been reviewed by xarray team member labels Dec 13, 2024
@spencerkclark
Copy link
Member

+1, indeed we can make cftime_range private.

@Maddogghoek
Copy link
Contributor

doubt anyone is waiting on this, but a quick status update, I need to add the expectation for the warning the doctest and replace the internal calls to cftime_range. Should have time tomorrow.

Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 7, 2025
- update other examples that call cftime_range to use date_range(use_cftime=True) instead

Issue pydata#9886
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 7, 2025
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 8, 2025
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 8, 2025
@Maddogghoek
Copy link
Contributor

finally got all the tests passing and the pull request is ready to go.

Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 11, 2025
per code review

issue pydata#9886

Co-authored-by: Maximilian Roos <[email protected]>
Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 14, 2025
Fix typo in (s/true/True) in what's new for issue pydata#9886 change.

Co-authored-by: Kai Mühlbauer <[email protected]>
Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 18, 2025
listed under deprecations instead

Co-authored-by: Spencer Clark <[email protected]>
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 18, 2025
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 18, 2025
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 18, 2025
Maddogghoek pushed a commit to Maddogghoek/xarray that referenced this issue Feb 18, 2025
Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 21, 2025
Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 21, 2025
Maddogghoek added a commit to Maddogghoek/xarray that referenced this issue Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants