Replace the constant BUILTINS by the string 'builtins'

 This make for clearer and also sligtly faster code (means time
 seems to decrese by 0.68% with this change alone (astroid/pylint)
 in the pylint tests benchmarks). Done because we were using an
 import from astroid from astroid.bases for one of those, which is
 kinda messy.

Author: Pierre-Sassoulas

ChangeLog

@@ -6,7 +6,8 @@ What's New in astroid 2.8.0?
 ============================
 Release date: TBA
 
-
+* ``astroid.const.BUILTINS`` and ``astroid.bases.BUILTINS`` have been removed,
+  simply replace this by the string 'builtins' for better performances.
 
 What's New in astroid 2.7.2?
 ============================

astroid/bases.py

@@ -29,7 +29,7 @@
 
 from astroid import context as contextmod
 from astroid import decorators, util
-from astroid.const import BUILTINS, PY310_PLUS
+from astroid.const import PY310_PLUS
 from astroid.exceptions import (
     AstroidTypeError,
     AttributeInferenceError,
@@ -45,7 +45,7 @@
 # TODO: check if needs special treatment
 BOOL_SPECIAL_METHOD = "__bool__"
 
-PROPERTIES = {BUILTINS + ".property", "abc.abstractproperty"}
+PROPERTIES = {"builtins.property", "abc.abstractproperty"}
 if PY310_PLUS:
     PROPERTIES.add("enum.property")
 
@@ -94,7 +94,7 @@ def _is_property(meth, context=None):
                 if base_class.__class__.__name__ != "Name":
                     continue
                 module, _ = base_class.lookup(base_class.name)
-                if module.name == BUILTINS and base_class.name == "property":
+                if module.name == "builtins" and base_class.name == "property":
                     return True
 
     return False
@@ -394,7 +394,7 @@ def infer_call_result(self, caller, context):
         # instance of the class given as first argument.
         if (
             self._proxied.name == "__new__"
-            and self._proxied.parent.frame().qname() == "%s.object" % BUILTINS
+            and self._proxied.parent.frame().qname() == "builtins.object"
         ):
             if caller.args:
                 node_context = context.extra_context.get(caller.args[0])
@@ -445,7 +445,7 @@ def _infer_type_new_call(self, caller, context):
         if mcs.__class__.__name__ != "ClassDef":
             # Not a valid first argument.
             return None
-        if not mcs.is_subtype_of("%s.type" % BUILTINS):
+        if not mcs.is_subtype_of("builtins.type"):
             # Not a valid metaclass.
             return None
 
@@ -558,7 +558,7 @@ def callable(self):
         return False
 
     def pytype(self):
-        return "%s.generator" % BUILTINS
+        return "builtins.generator"
 
     def display_type(self):
         return "Generator"
@@ -579,7 +579,7 @@ class AsyncGenerator(Generator):
     """Special node representing an async generator"""
 
     def pytype(self):
-        return "%s.async_generator" % BUILTINS
+        return "builtins.async_generator"
 
     def display_type(self):
         return "AsyncGenerator"

astroid/const.py

@@ -1,4 +1,3 @@
-import builtins
 import enum
 import sys
 
@@ -18,5 +17,3 @@ class Context(enum.Enum):
 Load = Context.Load
 Store = Context.Store
 Del = Context.Del
-
-BUILTINS = builtins.__name__  # Could be just 'builtins' ?

astroid/helpers.py

@@ -21,7 +21,6 @@
 from astroid import bases
 from astroid import context as contextmod
 from astroid import manager, nodes, raw_building, util
-from astroid.const import BUILTINS
 from astroid.exceptions import (
     AstroidTypeError,
     AttributeInferenceError,
@@ -40,7 +39,7 @@ def _build_proxy_class(cls_name, builtins):
 
 def _function_type(function, builtins):
     if isinstance(function, scoped_nodes.Lambda):
-        if function.root().name == BUILTINS:
+        if function.root().name == "builtins":
             cls_name = "builtin_function_or_method"
         else:
             cls_name = "function"

astroid/nodes/node_classes.py

@@ -45,7 +45,7 @@
 from astroid import bases
 from astroid import context as contextmod
 from astroid import decorators, mixins, util
-from astroid.const import BUILTINS, Context
+from astroid.const import Context
 from astroid.exceptions import (
     AstroidIndexError,
     AstroidTypeError,
@@ -2191,7 +2191,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.dict" % BUILTINS
+        return "builtins.dict"
 
     def get_children(self):
         """Get the key and value nodes below this node.
@@ -3083,7 +3083,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.list" % BUILTINS
+        return "builtins.list"
 
     def getitem(self, index, context=None):
         """Get an item from this node.
@@ -3278,7 +3278,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.set" % BUILTINS
+        return "builtins.set"
 
 
 class Slice(NodeNG):
@@ -3356,7 +3356,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.slice" % BUILTINS
+        return "builtins.slice"
 
     def igetattr(self, attrname, context=None):
         """Infer the possible values of the given attribute on the slice.
@@ -3710,7 +3710,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.tuple" % BUILTINS
+        return "builtins.tuple"
 
     def getitem(self, index, context=None):
         """Get an item from this node.

astroid/nodes/scoped_nodes.py

@@ -49,7 +49,7 @@
 from astroid import context as contextmod
 from astroid import decorators as decorators_mod
 from astroid import mixins, util
-from astroid.const import BUILTINS, PY39_PLUS
+from astroid.const import PY39_PLUS
 from astroid.exceptions import (
     AstroidBuildingError,
     AstroidTypeError,
@@ -575,7 +575,7 @@ def pytype(self):
         :returns: The name of the type.
         :rtype: str
         """
-        return "%s.module" % BUILTINS
+        return "builtins.module"
 
     def display_type(self):
         """A human readable type of this node.
@@ -1137,9 +1137,9 @@ def _infer_decorator_callchain(node):
     if isinstance(result, bases.Instance):
         result = result._proxied
     if isinstance(result, ClassDef):
-        if result.is_subtype_of("%s.classmethod" % BUILTINS):
+        if result.is_subtype_of("builtins.classmethod"):
             return "classmethod"
-        if result.is_subtype_of("%s.staticmethod" % BUILTINS):
+        if result.is_subtype_of("builtins.staticmethod"):
             return "staticmethod"
     if isinstance(result, FunctionDef):
         if not result.decorators:
@@ -1152,7 +1152,7 @@ def _infer_decorator_callchain(node):
             if (
                 isinstance(decorator, node_classes.Attribute)
                 and isinstance(decorator.expr, node_classes.Name)
-                and decorator.expr.name == BUILTINS
+                and decorator.expr.name == "builtins"
                 and decorator.attrname in BUILTIN_DESCRIPTORS
             ):
                 return decorator.attrname
@@ -1241,8 +1241,8 @@ def pytype(self):
         :rtype: str
         """
         if "method" in self.type:
-            return "%s.instancemethod" % BUILTINS
-        return "%s.function" % BUILTINS
+            return "builtins.instancemethod"
+        return "builtins.function"
 
     def display_type(self):
         """A human readable type of this node.
@@ -1541,7 +1541,7 @@ def type(
             if (
                 isinstance(node, node_classes.Attribute)
                 and isinstance(node.expr, node_classes.Name)
-                and node.expr.name == BUILTINS
+                and node.expr.name == "builtins"
                 and node.attrname in BUILTIN_DESCRIPTORS
             ):
                 return node.attrname
@@ -1571,9 +1571,9 @@ def type(
                     for ancestor in inferred.ancestors():
                         if not isinstance(ancestor, ClassDef):
                             continue
-                        if ancestor.is_subtype_of("%s.classmethod" % BUILTINS):
+                        if ancestor.is_subtype_of("builtins.classmethod"):
                             return "classmethod"
-                        if ancestor.is_subtype_of("%s.staticmethod" % BUILTINS):
+                        if ancestor.is_subtype_of("builtins.staticmethod"):
                             return "staticmethod"
             except InferenceError:
                 pass
@@ -2162,8 +2162,8 @@ def pytype(self):
         :rtype: str
         """
         if self.newstyle:
-            return "%s.type" % BUILTINS
-        return "%s.classobj" % BUILTINS
+            return "builtins.type"
+        return "builtins.classobj"
 
     def display_type(self):
         """A human readable type of this node.
@@ -2250,7 +2250,7 @@ def _infer_type_call(self, caller, context):
 
     def infer_call_result(self, caller, context=None):
         """infer what a class is returning when called"""
-        if self.is_subtype_of(f"{BUILTINS}.type", context) and len(caller.args) == 3:
+        if self.is_subtype_of("builtins.type", context) and len(caller.args) == 3:
             result = self._infer_type_call(caller, context)
             yield result
             return
@@ -2666,7 +2666,7 @@ def has_dynamic_getattr(self, context=None):
 
         def _valid_getattr(node):
             root = node.root()
-            return root.name != BUILTINS and getattr(root, "pure_python", None)
+            return root.name != "builtins" and getattr(root, "pure_python", None)
 
         try:
             return _valid_getattr(self.getattr("__getattr__", context)[0])

astroid/objects.py

@@ -23,7 +23,6 @@
 
 
 from astroid import bases, decorators, util
-from astroid.const import BUILTINS
 from astroid.exceptions import (
     AttributeInferenceError,
     InferenceError,
@@ -40,7 +39,7 @@ class FrozenSet(node_classes.BaseContainer):
     """class representing a FrozenSet composite node"""
 
     def pytype(self):
-        return "%s.frozenset" % BUILTINS
+        return "builtins.frozenset"
 
     def _infer(self, context=None):
         yield self
@@ -120,7 +119,7 @@ def _proxied(self):
         return ast_builtins.getattr("super")[0]
 
     def pytype(self):
-        return "%s.super" % BUILTINS
+        return "builtins.super"
 
     def display_type(self):
         return "Super of"
@@ -307,7 +306,7 @@ def __init__(
     type = "property"
 
     def pytype(self):
-        return "%s.property" % BUILTINS
+        return "builtins.property"
 
     def infer_call_result(self, caller=None, context=None):
         raise InferenceError("Properties are not callable")

tests/resources.py

@@ -15,7 +15,6 @@
 import sys
 
 from astroid import builder
-from astroid.bases import BUILTINS
 from astroid.manager import AstroidManager
 
 DATA_DIR = os.path.join("testdata", "python3")
@@ -58,9 +57,9 @@ class AstroidCacheSetupMixin:
 
     @classmethod
     def setup_class(cls):
-        cls._builtins = AstroidManager().astroid_cache.get(BUILTINS)
+        cls._builtins = AstroidManager().astroid_cache.get("builtins")
 
     @classmethod
     def teardown_class(cls):
         if cls._builtins:
-            AstroidManager().astroid_cache[BUILTINS] = cls._builtins
+            AstroidManager().astroid_cache["builtins"] = cls._builtins

tests/unittest_brain.py

@@ -695,7 +695,7 @@ def test_multiprocessing_manager(self):
 
         for attr in ("list", "dict"):
             obj = next(module[attr].infer())
-            self.assertEqual(obj.qname(), f"{bases.BUILTINS}.{attr}")
+            self.assertEqual(obj.qname(), f"builtins.{attr}")
 
         # pypy's implementation of array.__spec__ return None. This causes problems for this inference.
         if not hasattr(sys, "pypy_version_info"):
@@ -771,10 +771,9 @@ def mymethod(self, x):
         one = enumeration["one"]
         self.assertEqual(one.pytype(), ".MyEnum.one")
 
-        property_type = f"{bases.BUILTINS}.property"
         for propname in ("name", "value"):
             prop = next(iter(one.getattr(propname)))
-            self.assertIn(property_type, prop.decoratornames())
+            self.assertIn("builtins.property", prop.decoratornames())
 
         meth = one.getattr("mymethod")[0]
         self.assertIsInstance(meth, astroid.FunctionDef)
@@ -861,9 +860,8 @@ class MyEnum(enum.IntEnum):
         one = enumeration["one"]
 
         clazz = one.getattr("__class__")[0]
-        int_type = f"{bases.BUILTINS}.int"
         self.assertTrue(
-            clazz.is_subtype_of(int_type),
+            clazz.is_subtype_of("builtins.int"),
             "IntEnum based enums should be a subtype of int",
         )
 

tests/unittest_builder.py

@@ -31,7 +31,7 @@
 import pytest
 
 from astroid import Instance, builder, nodes, test_utils, util
-from astroid.const import BUILTINS, PY38_PLUS
+from astroid.const import PY38_PLUS
 from astroid.exceptions import (
     AstroidBuildingError,
     AstroidSyntaxError,
@@ -287,7 +287,7 @@ def test_missing_file(self):
 
     def test_inspect_build0(self):
         """test astroid tree build from a living object"""
-        builtin_ast = self.manager.ast_from_module_name(BUILTINS)
+        builtin_ast = self.manager.ast_from_module_name("builtins")
         # just check type and object are there
         builtin_ast.getattr("type")
         objectastroid = builtin_ast.getattr("object")[0]
@@ -314,7 +314,7 @@ def test_inspect_build3(self):
         self.builder.inspect_build(unittest)
 
     def test_inspect_build_type_object(self):
-        builtin_ast = self.manager.ast_from_module_name(BUILTINS)
+        builtin_ast = self.manager.ast_from_module_name("builtins")
 
         inferred = list(builtin_ast.igetattr("object"))
         self.assertEqual(len(inferred), 1)