Skip to content

The argument N is partially ignored in causalpy.data.simulate_data.generate_time_series_data  #433

@JovanVeljanoski

Description

@JovanVeljanoski

Hi there!

I am not sure if I understand the code exactly right, but i believe that the N argment in causalpy.data.simulate_data.generate_time_series_data is being ignored.

From the docstrings I think that the N is not propagated through the function (everywhere) and in many cases 100 is hardcoded.

If I am right, I would be happy to submit a PR for this. If it is more involved, please advise.

Cheers!
(in general quite happy with this project!)

P.S.: In the same function, should the input intercept (i.e. beta_intercept) in the output dataframe instead of the constant 1 ?

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions