-
Notifications
You must be signed in to change notification settings - Fork 88
Update pyproject.toml, including stricter linting rules
#571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Does this one need a rebase? |
1769678 to
ce23675
Compare
|
Remote tests failing saying test coverage is 0%, which is obviously not true. Debugging... |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 91.95% 88.72% -3.24%
==========================================
Files 33 33
Lines 4776 4844 +68
Branches 0 352 +352
==========================================
- Hits 4392 4298 -94
- Misses 384 428 +44
- Partials 0 118 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR modernizes our
pyproject.tomlconfiguration and enables stricter linting rules to catch potential bugs and improve code quality.Changes to
pyproject.tomlsource,branch,show_missing, andfail_under=80thresholdpython_versionandcheck_untyped_defssettingspathlibfrom dev dependencies (standard library)Code Fixes
Fixed 27 linting errors across the codebase to comply with new stricter rules:
stacklevelto warningsstrict=parameter tozip()callsisinstance()calls to use|syntax (Python 3.10+)Pre-commit Configuration
exclude: ^docs/to ruff pre-commit hook to avoid applying strict rules to example notebooksTesting
📚 Documentation preview 📚: https://causalpy--571.org.readthedocs.build/en/571/