Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: What's with the Pink Presets? #411

Open
gselzer opened this issue Mar 11, 2025 · 5 comments
Open

docs: What's with the Pink Presets? #411

gselzer opened this issue Mar 11, 2025 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@gselzer
Copy link
Contributor

gselzer commented Mar 11, 2025

After a fair amount of digging into the source code, I can see that pink text specifies that there is no preset that can capture the current system state, however this was not clear to me (without digging into the code) - this may well be something astute users can pick up on, but not me! (I actually discussed this with @marktsuchida multiple times 😅)

At a minimum, I'd appreciate if this shows up in documentation somewhere. Ideally, the tooltip would explain the situation. Happy to implement any agreed upon changes.

Looking back at mmstudio, if no preset matches the system state, the combo box is cleared, which I think more clearly signifies that no preset applies to this situation. @fdrgsp is there a reason you prefer the pink text? The use of color does help to grab attention to the preset...

Another disadvantage of the cleared combobox in mmstudio is that if you click on a blank preset box, the system state will change when it loses focus.

@gselzer gselzer added the documentation Improvements or additions to documentation label Mar 11, 2025
@fdrgsp
Copy link
Collaborator

fdrgsp commented Mar 12, 2025

Hey @gselzer, when we created the widget, I chose to use a color instead of leaving the field empty as a personal preference. It doesn’t have to be magenta; we could use light gray, for example, to give it a “disabled” appearance. We can also add to the first line of the tooltip something indicating that the preset is not set.
However, if everybody thinks it is confusing we can think about going back to the empty combo...

@tlambert03
Copy link
Member

it does seem like a number of people have been confused by it. Color aside: perhaps even just having the "last" commanded setting is too distracting and it should be all or nothing. So yeah: empty combo works for me

@gselzer
Copy link
Contributor Author

gselzer commented Mar 12, 2025

It doesn’t have to be magenta; we could use light gray, for example, to give it a “disabled” appearance.

Well, I think the color you did choose is quite nice - it has sufficient contrast to grab your attention. I would think a more red color would be nice to convey the meaning of "something's not right here", although that would deviate from the green/pink theme the widgets have.

However, if everybody thinks it is confusing we can think about going back to the empty combo...

I could certainly attempt a fix. The one UI feature I'd want to make sure we include if we go in that direction is that, if a combobox is empty/magenta, if you click it (just to view the options) and then click off of it, that should not trigger the setting of any preset (as it seems to do in mmstudio)

@marktsuchida
Copy link

marktsuchida commented Mar 13, 2025

if a combobox is empty/magenta, if you click it (just to view the options) and then click off of it, that should not trigger the setting of any preset

This will be nice indeed.

My vote is for not showing the last matching preset, not just because it may not even be approximately correct in many situations, but also because that information is not easy to obtain correctly (if there is no match when the widget is created, how would it know what the last matching preset was?).

On the other hand, the meaning of the empty box is also not always clear to people, I have seen. It might be nice to show something like <no match> in this case, if not too hard (maybe in italics or color, though I'd vote for something like gray rather than magenta).

@gselzer
Copy link
Contributor Author

gselzer commented Mar 13, 2025

It might be nice to show something like <no match> in this case, if not too hard

Ooh, I like something along this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants