Support extras in custom urls [integration] #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hoodmane
reviewed
Oct 18, 2025
| ) | ||
|
|
||
| async def add_requirement_inner( | ||
| async def add_requirement_inner( # noqa: C901 |
There was a problem hiding this comment.
Out of curiosity, what's C901?
There was a problem hiding this comment.
It is Function is too complex (C901). It is too giant function now and we'll need to refactor it later.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #254
Close #205
This changes the behavior of micropip.install to install
extraswhen the requirement is given informat.
I noticed that we already support
pkg @ https://pkg.url.com/pkg.whlsyntax thanks topackaging, but we were not handling the extras correctly. This PR fixes it.