Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affected ranges in PYSEC-2019-169 #80

Open
afdesk opened this issue Jun 2, 2022 · 6 comments
Open

affected ranges in PYSEC-2019-169 #80

afdesk opened this issue Jun 2, 2022 · 6 comments

Comments

@afdesk
Copy link

afdesk commented Jun 2, 2022

Hi Team!
thanks for your database! it's really useful content.

a few day ago we ran into a strange affected range in PYSEC-2019-169:

events:
- introduced: 2.1.0
- introduced: 2.3.0
- fixed: 2.3.2
- introduced: 1.0.2
- introduced: 2.0.0
- introduced: 2.2.0
- fixed: 2.2.3

Looks like the security advisory doesn't comply with the schema of Open Source Vulnerability.
https://ossf.github.io/osv-schema/

the next records are redundant:

 - introduced: 2.1.0 
 ...
 - introduced: 2.0.0 
 - introduced: 2.2.0 
 ...

GHSA contains a more shorter entry for CVE-2018-11760

Affected versions
">= 2.3.0, < 2.3.2"
"< 2.2.2"

That weird advisory breaks the Trivy's database. We're asking PyPA to check if it is a bug or not.

thanks!

@oliverchang
Copy link
Contributor

Hi there! This was scraped from the NVD CVE database, which resulted in these redundant entries.

While these are redundant entries, they don't necessarily conflict with OSV schema. These "events" represent points on the version timeline for describing which ranges are vulnerable. There are no ordering requirements for the actual encoding itself.

This encoding means:
1.0.2 (vulnerable) ---> 2.0.0 (vulnerable) --> 2.1.0 (vulnerable) --> 2.2.0 (vulnerable) --> 2.2.3 (fixed) --> 2.3.0 (vulnerable) --> 2.3.2 (fixed)

The first few vulnerable events are redundant -- this could be expressed more concisely as:

introduced: 1.0.2
fixed: 2.2.3
introduced: 2.3.0
fixed: 2.3.2

Note that this is slightly different from GitHub's encoding: they claim 2.2.2 is fixed but the CVE description claims it's not.

@afdesk
Copy link
Author

afdesk commented Jun 3, 2022

introduced: 1.0.2
fixed: 2.2.3
introduced: 2.3.0
fixed: 2.3.2

@oliverchang this records look good. thanks!

yes, it seems GHSA contains incorrect fixed version...

@oliverchang
Copy link
Contributor

introduced: 1.0.2
fixed: 2.2.3
introduced: 2.3.0
fixed: 2.3.2

@oliverchang this records look good. thanks!

yes, it seems GHSA contains incorrect fixed version...

👍 I'd recommend in either case to be able to handle the original encoding, since it's still consistent with the OSV schema.

@afdesk
Copy link
Author

afdesk commented Jun 3, 2022

ok, we'll take a look at this moment. thanks again.

@westonsteimel
Copy link
Collaborator

@oliverchang did you want to submit an update to the GitHub advisory? Otherwise I can on Monday. I think this Jira link should be sufficient to show that 2.2.3 is the fix version: https://issues.apache.org/jira/browse/SPARK-26802

@westonsteimel
Copy link
Collaborator

Nevermind, it was quick enough I just went ahead and submitted it now: github/advisory-database#362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants