Skip to content

Fragile path handling #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theamericanaccount opened this issue Nov 5, 2024 · 0 comments
Open

Fragile path handling #208

theamericanaccount opened this issue Nov 5, 2024 · 0 comments

Comments

@theamericanaccount
Copy link

theamericanaccount commented Nov 5, 2024

If the path from which the module is loaded contains a double colon the program breaks. I suppose this happened because code could have been written from a Windows environment.

I'm attaching a limited partial fix which simply reports the user why the program fails to run with a merge request.
I would say whole subprocessing should be handled better though, if not scrapped entirely.

EDIT:
I've just seen there's a merge request already opened switching from string to path type which may fix this issue already, I'm gonna test it now.

EDIT2:
I've tested maxgot23 code and does not fix the issue.
Opening my extra error merge request as well and waiting for next person bothered by this issue to merge our efforts and solve it definitely.

EDIT3: I can't open a merge request for a repo which has not generated through the 'fork' button so this is the link to the repo containing the fix:
https://github.com/themartiancompany/pyproject-hooks
version 1.2.1 contains it.
This is max unpaid effort you can expect from me currently.

EDIT4: an ur source recipe targeting version 1.2.1 is published on the github ur mirror. an android life / dogeos package has been published on the fur instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant