fix: restrict template views to warehouse domain

The template view wrapper allows for setting a domain, but these pages
never had one set, and thus were served on other endpoints.

Signed-off-by: Mike Fiedler <[email protected]>

Author: miketheman

tests/unit/test_routes.py

@@ -647,27 +647,35 @@ def add_redirect_rule(*args, **kwargs):
             "sitemap",
             "/sitemap/",
             "pages/sitemap.html",
+            route_kw={"domain": warehouse},
             view_kw={"has_translations": True},
         ),
         pretend.call(
-            "help", "/help/", "pages/help.html", view_kw={"has_translations": True}
+            "help",
+            "/help/",
+            "pages/help.html",
+            route_kw={"domain": warehouse},
+            view_kw={"has_translations": True},
         ),
         pretend.call(
             "security",
             "/security/",
             "pages/security.html",
+            route_kw={"domain": warehouse},
             view_kw={"has_translations": True},
         ),
         pretend.call(
             "sponsors",
             "/sponsors/",
             "pages/sponsors.html",
+            route_kw={"domain": warehouse},
             view_kw={"has_translations": True},
         ),
         pretend.call(
             "trademarks",
             "/trademarks/",
             "pages/trademarks.html",
+            route_kw={"domain": warehouse},
             view_kw={"has_translations": True},
         ),
     ]

warehouse/routes.py

@@ -29,15 +29,24 @@ def includeme(config):
 
     # Some static, template driven pages
     config.add_template_view(
-        "sitemap", "/sitemap/", "pages/sitemap.html", view_kw={"has_translations": True}
+        "sitemap",
+        "/sitemap/",
+        "pages/sitemap.html",
+        route_kw={"domain": warehouse},
+        view_kw={"has_translations": True},
     )
     config.add_template_view(
-        "help", "/help/", "pages/help.html", view_kw={"has_translations": True}
+        "help",
+        "/help/",
+        "pages/help.html",
+        route_kw={"domain": warehouse},
+        view_kw={"has_translations": True},
     )
     config.add_template_view(
         "security",
         "/security/",
         "pages/security.html",
+        route_kw={"domain": warehouse},
         view_kw={"has_translations": True},
     )
     # Redirect the old "sponsor PyPI" page to the sponsors page
@@ -46,6 +55,7 @@ def includeme(config):
         "sponsors",
         "/sponsors/",
         "pages/sponsors.html",
+        route_kw={"domain": warehouse},
         view_kw={"has_translations": True},
     )
 
@@ -63,6 +73,7 @@ def includeme(config):
         "trademarks",
         "/trademarks/",
         "pages/trademarks.html",
+        route_kw={"domain": warehouse},
         view_kw={"has_translations": True},
     )