Skip to content

Commit 83b0b8b

Browse files
authored
Merge pull request #993 from ArthurSens/fix-992
2 parents 875ff1d + 7cf76ea commit 83b0b8b

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

kubernetes/controllers/servicelevelobjective.go

+4-5
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,9 @@ func (r *ServiceLevelObjectiveReconciler) reconcilePrometheusRule(ctx context.Co
7979
if err := r.Create(ctx, newRule); err != nil {
8080
return ctrl.Result{}, err
8181
}
82-
return ctrl.Result{}, fmt.Errorf("failed to create prometheus rule: %w", err)
82+
} else {
83+
return ctrl.Result{}, fmt.Errorf("failed to get prometheus rule: %w", err)
8384
}
84-
85-
return ctrl.Result{}, fmt.Errorf("failed to get prometheus rule: %w", err)
8685
}
8786

8887
newRule.ResourceVersion = rule.ResourceVersion
@@ -123,9 +122,9 @@ func (r *ServiceLevelObjectiveReconciler) reconcileConfigMap(
123122
if err := r.Create(ctx, newConfigMap); err != nil {
124123
return ctrl.Result{}, fmt.Errorf("failed to create config map: %w", err)
125124
}
125+
} else {
126+
return ctrl.Result{}, fmt.Errorf("failed to get config map: %w", err)
126127
}
127-
128-
return ctrl.Result{}, err
129128
}
130129

131130
newConfigMap.ResourceVersion = existingConfigMap.ResourceVersion

0 commit comments

Comments
 (0)