Skip to content

Commit ef1494b

Browse files
committed
slo: Update test after fixing apiserver read latency example
1 parent 196f6b3 commit ef1494b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

slo/promql_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ func TestObjective_QueryTotal(t *testing.T) {
316316
}, {
317317
name: "apiserver-read-resource-latency",
318318
objective: objectiveAPIServerLatency(),
319-
expected: `sum(apiserver_request_duration_seconds:increase2w{job="apiserver",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"})`,
319+
expected: `sum by(resource, verb) (apiserver_request_duration_seconds:increase2w{job="apiserver",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"})`,
320320
}}
321321
for _, tc := range testcases {
322322
t.Run(tc.name, func(t *testing.T) {
@@ -385,7 +385,7 @@ func TestObjective_QueryErrors(t *testing.T) {
385385
}, {
386386
name: "apiserver-read-resource-latency",
387387
objective: objectiveAPIServerLatency(),
388-
expected: `sum(apiserver_request_duration_seconds:increase2w{job="apiserver",le="",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"}) - sum(apiserver_request_duration_seconds:increase2w{job="apiserver",le="0.1",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"})`,
388+
expected: `sum by(resource, verb) (apiserver_request_duration_seconds:increase2w{job="apiserver",le="",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"}) - sum by(resource, verb) (apiserver_request_duration_seconds:increase2w{job="apiserver",le="0.1",resource=~"resource|",slo="apiserver-read-resource-latency",verb=~"LIST|GET"})`,
389389
}}
390390
for _, tc := range testcases {
391391
t.Run(tc.name, func(t *testing.T) {

0 commit comments

Comments
 (0)