Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py fails in environments where locale != *utf8 #127

Closed
sdelafond opened this issue Jul 5, 2017 · 3 comments
Closed

setup.py fails in environments where locale != *utf8 #127

sdelafond opened this issue Jul 5, 2017 · 3 comments

Comments

@sdelafond
Copy link
Contributor

sdelafond commented Jul 5, 2017 •
edited
Loading

With python3.5, in a "regular" C locale, opening HISTORY.rst fails because that file is utf8-encoded (python2.7 doesn't complain about that).
@Lukasa
Copy link
Member

Lukasa commented Jul 5, 2017

Yup, that seems like a likely problem. Mind supplying a PR to resolve the issue?

@sdelafond
Copy link
Contributor Author

I was gonna add encoding=utf-8 to the open call, but that won't work in 2.7 unfortunately...

@Lukasa
Copy link
Member

Lukasa commented Jul 5, 2017

@sdelafond You want codecs.open.

@Lukasa Lukasa closed this as completed in 146abd6 Jul 5, 2017
Lukasa added a commit that referenced this issue Jul 5, 2017
@Lukasa
Merge pull request #128 from sdelafond/master
e8a9e15 
Use codecs.open() with encoding='utf-8' for python3.x (Closes: #127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdelafond @Lukasa