Write to temp file in byte mode. Added extra test case for classic macOS line endings.

Author: freebird-2

pylsp_mypy/plugin.py

@@ -51,7 +51,7 @@
 
 settingsCache: Dict[str, Dict[str, Any]] = {}
 
-tmpFile: Optional[IO[str]] = None
+tmpFile: Optional[IO[bytes]] = None
 
 # In non-live-mode the file contents aren't updated.
 # Returning an empty diagnostic clears the diagnostic result,
@@ -295,11 +295,11 @@ def get_diagnostics(
     global tmpFile
     if live_mode and not is_saved:
         if tmpFile:
-            tmpFile = open(tmpFile.name, "w", encoding="utf-8", newline="")
+            tmpFile = open(tmpFile.name, "wb")
         else:
-            tmpFile = tempfile.NamedTemporaryFile("w", delete=False, encoding="utf-8", newline="")
+            tmpFile = tempfile.NamedTemporaryFile("wb", delete=False)
         log.info("live_mode tmpFile = %s", tmpFile.name)
-        tmpFile.write(document.source)
+        tmpFile.write(bytes(document.source, "utf-8"))
         tmpFile.close()
         args.extend(["--shadow-file", document.path, tmpFile.name])
     elif not is_saved and document.path in last_diagnostics:

test/test_plugin.py

@@ -83,7 +83,7 @@ def test_plugin(workspace, last_diagnostics_monkeypatch):
     assert diag["code"] == "attr-defined"
 
 
-@pytest.mark.parametrize("doc_source", ["a = 1\nb\n", "a = 1\r\nb\r\n"])
+@pytest.mark.parametrize("doc_source", ["a = 1\nb\n", "a = 1\r\nb\r\n", "a = 1\rb\r"])
 def test_handling_of_line_endings(workspace, last_diagnostics_monkeypatch, doc_source):
     # setup
     doc = Document(DOC_URI, workspace, doc_source)