Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from pytest_runtest_call → pytest_runtest_setup? #52

Open
njsmith opened this issue Jul 24, 2018 · 0 comments
Open

Switch from pytest_runtest_call → pytest_runtest_setup? #52

njsmith opened this issue Jul 24, 2018 · 0 comments

Comments

@njsmith
Copy link
Member

njsmith commented Jul 24, 2018

Right now we have to jump through hoops to make sure our pytest_runtest_call runs as early as possible, because it doesn't actually want to run anything, it just wants to patch the test object before the real pytest_runtest_call hook runs.

There's also a hook called pytest_runtest_setup which is... kind of designed for exactly this. It seems like we should use it?

Unfortunately when I tried this, I got 1 test failure: in test_async_test_as_class_method, for some reason the test method TestInClass.test_base is not being detected as a trio test. Pytest is very mysterious sometimes.

At some point it would be good to dig into this and figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant