Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "master" to "main" #28

Closed
ambv opened this issue Nov 17, 2023 · 5 comments
Closed

Rename "master" to "main" #28

ambv opened this issue Nov 17, 2023 · 5 comments

Comments

@ambv
Copy link

ambv commented Nov 17, 2023

There is currently a hack to allow continued use of "master" as a branch for new uploaded results. This needs to go away. We've been using "main" for years.

@mattip
Copy link

mattip commented Jan 20, 2024

PyPy also came across this: we recently moved from Mercurial (default branch: "default") to Git (default branch: "main"). Unfortunately on the admin/project page, each project can only have one default branch. This means that we now need to choose whether to show Git results on the Timeline and Changes tabs for these projects, or to show Mercurial results. So it would be nice if there could be more than one default branch (a bit of an oxymoron). Then CPython could upload main results but still see the master ones as well.

@diegorusso
Copy link

We need to get to the bottom of it as this issues is preventing aarch64 results to be shown.

@mattip
Copy link

mattip commented Jan 23, 2024

Which tab is not presenting aarch64 results?
It appears the filtering happens here for the timeline tab.

@diegorusso
Copy link

diegorusso commented Jan 23, 2024

it is in the "changes" and "timeline" tabs. In the comparison tab, although not great) you have a way to select the branch via the executable.
Moving from Mercurial to Git can be done by creating a new project that points to the right mercurial or git repo. In this way you have a clean break to what is in mercurial and in git.
Instead in the case of git/master -> git->main, we just need to change the data in the database: all results related to master needs to be changed to main branch. This is "simply" a database query to update such data. Commits sha won't be changing if we change the branch name and everything will keep working as expected.

Once we have fixed the master/main issue, we should update the UI to allow the user to select branches explicitly in all three tabs (related issue #27) Instead of assuming the "default" branch we let the user what branch they want to see. If the user doesn't specify anything we can assume it will be "main" for git.

Thoughts?

@ambv
Copy link
Author

ambv commented Feb 28, 2024

Fixed, thanks, Diego!

@ambv ambv closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants