Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover code in sysconfig.expand_makefile_vars #128978

Open
picnixz opened this issue Jan 18, 2025 · 0 comments
Open

Leftover code in sysconfig.expand_makefile_vars #128978

picnixz opened this issue Jan 18, 2025 · 0 comments
Assignees
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@picnixz
Copy link
Member

picnixz commented Jan 18, 2025

Bug report

Bug description:

I think there is some leftover code in sysconfig.expand_makefile_vars (90d02e5):

while True:
m = re.search(_findvar1_rx, s) or re.search(_findvar2_rx, s)
if m:
(beg, end) = m.span()
s = s[0:beg] + vars.get(m.group(1)) + s[end:]
else:
break
return s

The _findvar1_rx and _findvar2_rx variables are not declared at all (they were moved to sysconfig/__main__.py). Since the function is publicly named (but not exported nor documented), I prefer backporting the changes of #110785, namely re-use the patterns as is.

cc @FFY00

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

@picnixz picnixz added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jan 18, 2025
@picnixz picnixz self-assigned this Jan 18, 2025
@picnixz picnixz added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes 3.12 bugs and security fixes labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant