Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 588: Update GitHub Issues Migration Plan #2497

Open
Tracked by #13
ezio-melotti opened this issue Apr 1, 2022 · 7 comments
Open
Tracked by #13

PEP 588: Update GitHub Issues Migration Plan #2497

ezio-melotti opened this issue Apr 1, 2022 · 7 comments
Assignees
Labels

Comments

@ezio-melotti
Copy link
Member

ezio-melotti commented Apr 1, 2022

PEP-0588 was written together with PEP-0581 and outlined a migration plan. Since then, several things changed and https://github.com/psf/gh-migration/projects/1 was created and updated to track the migration. Then, closer to the migration date, I wrote psf/gh-migration#13.

I discussed with the SC both the possibility of creating a new PR or updating PEP-0581, and IIRC they were leaning towards the latter, however it will need to be pretty much rewritten. Given that the migration is going to happen soon, the rewrite (or new pep) could serve the following purposes:

  • Clarify that PEP-0581 doesn't reflect the actual plan used for the migration if a new pep is written, or update it with up-to-date info;
  • Offer some background about the problems and the decisions taken (linking to relevant GH issues/discussions), including issue numbering, label mapping, user subscriptions, etc.;
  • Document the actual process followed during the migration and all the changes that were involved (this is the bulk of Migration and risk management plans psf/gh-migration#13);

IOW, it will mostly be an informational PEP to document the migration.

What do you think?

(CC @Mariatta)

@ezio-melotti ezio-melotti self-assigned this Apr 1, 2022
@hugovk hugovk changed the title Update PEP-588: GitHub Issues Migration Plan PEP-588: Update GitHub Issues Migration Plan Apr 1, 2022
@hugovk hugovk changed the title PEP-588: Update GitHub Issues Migration Plan PEP 588: Update GitHub Issues Migration Plan Apr 1, 2022
@warsaw
Copy link
Member

warsaw commented Apr 1, 2022

Clarify that PEP-0581 doesn't reflect the actual plan used for the migration if a new pep is written, or update it with up-to-date info;

Or just write a new PEP and make 581 Superseded-By it

@CAM-Gerlach
Copy link
Member

PEP 581 seems to just be a rationale for GitHub over BPO, rather than a description of the migration plan, which is in PEP 588. I can imagine some of the points changing somewhat in light of the experience implementing it, but I'm not sure the former needs a bottom to top rewrite, since it documents the rationale at the time of the decision.

As for PEP 588, playing devil's advocate here, but now that the change is on the eve of being implemented, if updating the current PEP isn't feasible (which would generally be preferable), is a new PEP really the right place for this, or is there another more better venue? @encukou , thoughts?

@encukou
Copy link
Member

encukou commented Apr 4, 2022

PEP 588 is a change proposal, so IMO it is the right place. Documentation about how devs should use/migrate to GH should go to devguide, but that's already the plan.
Only having the info in psf/gh-migration#13, and updating PEP 588 to point there, would also be OK as far as I'm concerned. Bu if there's more in-depth discussion/rationale to be added, a PEP seems better.

@Mariatta
Copy link
Member

Mariatta commented Apr 4, 2022

At the docs WG meeting today, the group agrees that PEP 588 is the right place to document the migration process, and that we should not create yet another PEP.

@hugovk
Copy link
Member

hugovk commented Jul 14, 2024

Two years later: do we still need to update PEP 588 beyond changing the status from Draft? Who can do it?

@willingc
Copy link
Contributor

@hugovk @warsaw @Mariatta Since this was an informational PEP when going from bpo to github and outlined potential options, what do you recommend for the next step other than Draft?

@hugovk
Copy link
Member

hugovk commented Aug 1, 2024

I suggest we don't spend a lot of time on the text. The PEP described the plan at one point in time. The migration is complete, and things inevitably changed during the process.

I don't think there's much value in updating the PEP to fully document what the plan actually was in the end: it's documented in psf/gh-migration#13, we're not going to repeat BPO->GH, and if another project is planning something similar, other things will have changed in the past few years for them to consider. They can still review the various PEPs and psf/gh-migration#13.

@encukou said:

Only having the info in psf/gh-migration#13, and updating PEP 588 to point there, would also be OK as far as I'm concerned.

This sounds good. Let's point the PEP to psf/gh-migration#13 and update the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants
@warsaw @encukou @hugovk @willingc @Mariatta @CAM-Gerlach @ezio-melotti and others