Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black selection color when using black text color and light background #19

Closed
Kzinux opened this issue Nov 9, 2024 · 4 comments · Fixed by #20
Closed

Black selection color when using black text color and light background #19

Kzinux opened this issue Nov 9, 2024 · 4 comments · Fixed by #20
Assignees
@pythops
Labels
enhancement New feature or request

Comments

@Kzinux
Copy link

Kzinux commented Nov 9, 2024

Wezterm on archlinux, impala 0.2.3.
The selection color made the text unreadable.
2024-11-09_17-51
@pythops pythops self-assigned this Nov 9, 2024
@pythops pythops added the enhancement New feature or request label Nov 9, 2024
@pythops pythops mentioned this issue Nov 9, 2024
Merged
@pythops
Copy link
Owner

pythops commented Nov 9, 2024

@Kzinux
can you try #20 PR

@Kzinux
Copy link
Author

Kzinux commented Nov 9, 2024

Thank you for your work.
My first time try to build rust code, the '#20 PR' fix the selection color.
Below is the newly build impala bin.
2024-11-09_19-46

@pythops
Copy link
Owner

pythops commented Nov 9, 2024

Great !
I will merge it then and might do a release next week

@pythops pythops closed this as completed Nov 9, 2024
@pythops
Copy link
Owner

pythops commented Nov 17, 2024

@Kzinux I have just released a new version with your changes. enjoy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pythops pythops

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix fg color for light mode pythops/impala
2 participants
@Kzinux @pythops