-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
We have the following test cases right now:
Lines 16 to 21 in 6cfa477
def test_torch_version_at_least(self): | |
test_cases = [ | |
("2.5.0a0+git9f17037", "2.5.0", True), | |
("2.5.0a0+git9f17037", "2.4.0", True), | |
("2.5.0.dev20240708+cu121", "2.5.0", True), | |
("2.5.0.dev20240708+cu121", "2.4.0", True), |
But this is wrong. The right order should be:
2.4.0 (stable) < 2.5.0.dev / 2.5.0.git < 2.5.0 (stable)
So actually 2.5.0.dev
and 2.5.0.git
are not "at least" 2.5.0.
jerryzh168
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers