Skip to content

Commit e49ed13

Browse files
committed
Update optimized lib to build on Windows
ghstack-source-id: a07137b ghstack-comment-id: 3208323478 Pull-Request: #13564
1 parent 580d7fc commit e49ed13

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/build-presets.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jobs:
109109
strategy:
110110
fail-fast: false
111111
matrix:
112-
preset: [windows] # TODO (gjcomer) Re-enable pybind once functional
112+
preset: [pybind, windows]
113113
with:
114114
job-name: build
115115
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
@@ -127,7 +127,7 @@ jobs:
127127
conda activate et
128128
129129
python install_requirements.py
130-
cmake --preset ${{ matrix.preset }}
130+
cmake --preset ${{ matrix.preset }} -T ClangCL
131131
if (\$LASTEXITCODE -ne 0) {
132132
Write-Host "CMake configuration was unsuccessful. Exit code: \$LASTEXITCODE."
133133
exit \$LASTEXITCODE

tools/cmake/preset/pybind.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,13 @@ set_overridable_option(EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR ON)
2121
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_DATA_LOADER ON)
2222
set_overridable_option(EXECUTORCH_BUILD_KERNELS_OPTIMIZED ON)
2323
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_MODULE ON)
24-
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TRAINING ON)
2524

2625
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
2726
set_overridable_option(EXECUTORCH_BUILD_COREML ON)
27+
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TRAINING ON)
2828
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
2929
set_overridable_option(EXECUTORCH_BUILD_COREML ON)
30+
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_TRAINING ON)
3031
elseif(CMAKE_SYSTEM_NAME STREQUAL "Windows" OR CMAKE_SYSTEM_NAME STREQUAL
3132
"WIN32"
3233
)

0 commit comments

Comments
 (0)