Add ETDump event tracer support to LLaMa runner #15934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navsud
requested review from
jackzhxng,
larryliu0820,
lucylq and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15934
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
navsud
force-pushed
the
export-D87122487
branch
from
279ca65 to
0cddd2e
Compare
larryliu0820
approved these changes
Nov 21, 2025
kimishpatel
approved these changes
Nov 21, 2025
Contributor
kimishpatel
left a comment
kimishpatel
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
navsud
force-pushed
the
export-D87122487
branch
from
0cddd2e to
14d847c
Compare
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Nov 22, 2025
Summary: for op-level profiling of od-llms **Addresses reviewer feedback:** - Added `ET_EVENT_TRACER_ENABLED` ifdef guards around ETDump code to ensure normal builds compile without event tracer support - Replaced hardcoded `/data/local/tmp/etdump.bin` path with configurable `--etdump_path` flag (default: `"etdump.in"`) - ETDumpGen is created only when compiled with event tracer support enabled Reviewed By: larryliu0820, kimishpatel Differential Revision: D87122487
navsud
force-pushed
the
export-D87122487
branch
from
14d847c to
5a75ac9
Compare
navsud
added a commit
to navsud/executorch
that referenced
this pull request
Nov 24, 2025
Summary: for op-level profiling of od-llms **Addresses reviewer feedback:** - Added `ET_EVENT_TRACER_ENABLED` ifdef guards around ETDump code to ensure normal builds compile without event tracer support - Replaced hardcoded `/data/local/tmp/etdump.bin` path with configurable `--etdump_path` flag (default: `"etdump.in"`) - ETDumpGen is created only when compiled with event tracer support enabled Reviewed By: larryliu0820, kimishpatel Differential Revision: D87122487
navsud
force-pushed
the
export-D87122487
branch
from
5a75ac9 to
18476e1
Compare
Summary: for op-level profiling of od-llms **Addresses reviewer feedback:** - Added `ET_EVENT_TRACER_ENABLED` ifdef guards around ETDump code to ensure normal builds compile without event tracer support - Replaced hardcoded `/data/local/tmp/etdump.bin` path with configurable `--etdump_path` flag (default: `"etdump.in"`) - ETDumpGen is created only when compiled with event tracer support enabled Reviewed By: larryliu0820, kimishpatel Differential Revision: D87122487
navsud
force-pushed
the
export-D87122487
branch
from
18476e1 to
0c7379f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
for op-level profiling of od-llms
Addresses reviewer feedback:
ET_EVENT_TRACER_ENABLEDifdef guards around ETDump code to ensure normal builds compile without event tracer support/data/local/tmp/etdump.binpath with configurable--etdump_pathflag (default:"etdump.in")Differential Revision: D87122487