Skip to content

add LSF scheduler #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takeshi-yoshimura wants to merge 5 commits into from
Closed

add LSF scheduler #588

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b039ed4
add lsf_scheduler.py
takeshi-yoshimura Aug 25, 2022
176349e
remove Singularity and DirWorkspace. and use shlex.join
takeshi-yoshimura Sep 20, 2022
8373713
fix lint errors
takeshi-yoshimura Oct 4, 2022
76c7411
fix pyre errors
takeshi-yoshimura Oct 4, 2022
f8e9a0b
add lsf_scheduler_test.py
takeshi-yoshimura Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion scripts/component_integration_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def main() -> None:
torchx_image = "dummy_image"
dryrun = False

if scheduler in ("kubernetes", "local_docker", "aws_batch"):
if scheduler in ("kubernetes", "local_docker", "aws_batch", "lsf"):

@d4l3k d4l3k Aug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any easy way for us to setup a local LSF scheduler in the CI test environment (i.e via docker)? Would be nice to have an E2E integration test like we do for the other schedulers

try:
build = build_and_push_image()
torchx_image = build.torchx_image
Expand Down Expand Up @@ -105,6 +105,17 @@ def main() -> None:
},
"workspace": f"file://{os.getcwd()}",
},
"lsf": {
"providers": [
component_provider,
],
"image": torchx_image,
"cfg": {
"runtime": "docker",
"jobdir": "/mnt/data/torchx",
"host_network": True,
},
},
}

params = run_parameters[scheduler]
Expand Down
1 change: 1 addition & 0 deletions torchx/schedulers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"kubernetes": "torchx.schedulers.kubernetes_scheduler",
"aws_batch": "torchx.schedulers.aws_batch_scheduler",
"ray": "torchx.schedulers.ray_scheduler",
"lsf": "torchx.schedulers.lsf_scheduler",
}


Expand Down
Loading