Skip to content

Why are sensible defaults in satpy not the defaults in pycoast? #34

@mraspaud

Description

@mraspaud

In Satpy there are defaults set here:

https://github.com/pytroll/satpy/blob/d86b21ac3f4c43148dcc9ccacec82564cc61ca00/satpy/enhancements/overlays.py#L123-L142

The comments suggest these are "sensible" defaults, but they are not the defaults in pycoast. For example, here is a dictionary of defaults in pycoast:

pycoast/pycoast/cw_base.py

Lines 1273 to 1283 in 293f4da

DEFAULT = {
"level": 1,
"outline": "white",
"width": 1,
"fill": None,
"fill_opacity": 255,
"outline_opacity": 255,
"x_offset": 0,
"y_offset": 0,
"resolution": default_resolution,
}

Where width and outline color defaults are different than in Satpy. So if Satpy's defaults are so sensible then maybe they should be the defaults in pycoast.

Original text

Why are these sensible defaults not the defaults in pycoast?

Originally posted by @djhoese in pytroll/satpy#934

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions