New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileListIterator should not swallow exception and return null #524

Open

wowxunyl opened this issue Jun 9, 2021 · 1 comment

wowxunyl commented Jun 9, 2021 •

edited

Loading

java-sdk/src/main/java/com/qiniu/storage/BucketManager.java

Line 1271 in 28bf849

public FileInfo[] next() {

        @Override
        public FileInfo[] next() {
            try {
                FileListing f = listFiles(bucket, prefix, marker, limit, delimiter);
                this.marker = f.marker == null ? "" : f.marker;
                return f.items;
            } catch (QiniuException e) {
                this.exception = e;
                return null;
            }
        }

here should fail fast so that user can know what happened

Author

wowxunyl commented Jun 9, 2021

PR: https://github.com/qiniu/java-sdk/pull/525/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment