Skip to content

Commit b84610d

Browse files
committed
Address review feedback on Pyrefly migration
Drop redundant typecheck problem matcher; use pyrefly --output-format github in CI. Add types-networkx to typecheck deps, trim ignore-missing-imports to optional imports only, and document temporarily disabled Pyrefly-only error kinds. Restore universal env pins (Python 3.10) while swapping mypy for pyrefly in dev/typecheck env files.
1 parent ea74aa1 commit b84610d

12 files changed

Lines changed: 610 additions & 71 deletions

File tree

.github/problem-matchers/README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ made available under the terms of the MIT license.
2828

2929
- [`pytest.json`](https://github.com/liskin/gh-problem-matcher-wrap/blob/master/problem-matchers/pytest.json)
3030

31-
The typecheck problem matcher matches Pyrefly's text and GitHub Actions output
32-
formats used by `check/typecheck`.
33-
34-
- [`typecheck.json`](./typecheck.json)
35-
3631
The actionlint problem matcher JSON file came from the
3732
[actionlint](https://github.com/rhysd/actionlint/blob/v1.7.7/docs/usage.md)
3833
documentation (copied on 2025-02-12, version 1.7.7). Actionlint is made

.github/problem-matchers/typecheck.json

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/ci.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,7 @@ jobs:
9696
check/pylint -j 0
9797
9898
- name: Check type declarations
99-
run: |
100-
echo '::add-matcher::.github/problem-matchers/typecheck.json'
101-
check/typecheck --output-format github
99+
run: check/typecheck --output-format github
102100

103101
pytest:
104102
name: Unit tests
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
11
pyrefly
2+
3+
types-networkx

dev_tools/requirements/envs/dev.env.txt

Lines changed: 235 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev_tools/requirements/envs/format.env.txt

Lines changed: 58 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev_tools/requirements/envs/pylint.env.txt

Lines changed: 75 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dev_tools/requirements/envs/pytest-extra.env.txt

Lines changed: 73 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)