REST Data extensions returns 400 when violations

Author: Sgitario

009-quarkus-infinispan-grpc-kafka/src/main/java/io/quarkus/qe/books/Book.java

@@ -24,7 +24,7 @@ public Book(String title, String description, int publicationYear) {
         this.publicationYear = publicationYear;
     }
 
-    @NotBlank(message = "Title may not be blank")
+    @NotBlank(message = "Title cannot be blank")
     @ProtoField(number = 1)
     public String getTitle() {
         return title;

009-quarkus-infinispan-grpc-kafka/src/test/java/io/quarkus/qe/books/BookServiceTest.java

@@ -1,6 +1,7 @@
 package io.quarkus.qe.books;
 
 import static io.restassured.RestAssured.given;
+import static org.hamcrest.Matchers.containsString;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 import org.apache.http.HttpStatus;
@@ -33,4 +34,14 @@ public void testBookResource() {
 
         assertEquals(BOOK, actual);
     }
+
+    @Test
+    public void testBookResourceShouldValidateBook() {
+        given()
+                .contentType(ContentType.JSON)
+                .body(new Book())
+                .when().post("/book/add")
+                .then().statusCode(HttpStatus.SC_BAD_REQUEST)
+                .body(containsString("Title cannot be blank"));
+    }
 }

011-quarkus-panache-rest-flyway/README.md

@@ -8,7 +8,3 @@ Topics covered here:
 - https://quarkus.io/guides/flyway
 
 In the future, I would like to cover different database at the same time.
-
-## Disabled tests
-
-`PostgreSqlApplicationResourceTest#shouldReturnBadRequestIfApplicationNameIsNull` - see https://github.com/quarkusio/quarkus/issues/13307

011-quarkus-panache-rest-flyway/src/main/java/io/quarkus/qe/ApplicationEntity.java

@@ -28,7 +28,7 @@
 @Filter(name = "useLikeByName", condition = "name like '%' || :name || '%'")
 @FilterDef(name = "useServiceByName", parameters = { @ParamDef(name = "name", type = "string") })
 public class ApplicationEntity extends PanacheEntity {
-    @NotEmpty
+    @NotEmpty(message = "name can't be null")
     @Column(unique = true, nullable = false)
     public String name;
 

011-quarkus-panache-rest-flyway/src/test/java/io/quarkus/qe/PostgreSqlApplicationResourceTest.java

@@ -15,7 +15,6 @@
 
 import org.apache.http.HttpStatus;
 import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import io.quarkus.qe.containers.PostgreSqlDatabaseTestResource;
@@ -68,16 +67,13 @@ public void shouldDeleteApplication() {
         thenApplicationsCountIs(0);
     }
 
-    /**
-     * This test is disabled because the conflict exception raised by hibernate validator is wrapping it up by the rollback
-     * exception which ends up in a HTTP 500 Internal Server Error instead of a HTTP 409 Conflict.
-     */
-    @Disabled("Caused by https://github.com/quarkusio/quarkus/issues/13307.")
     @Test
     public void shouldReturnBadRequestIfApplicationNameIsNull() {
         applicationPath().body(new ApplicationEntity()).post()
                 .then()
-                .statusCode(HttpStatus.SC_CONFLICT);
+                .statusCode(HttpStatus.SC_BAD_REQUEST);
+                // TODO: Body assertion is not working caused by https://github.com/quarkusio/quarkus/issues/15492
+                // .body(containsString("name can't be null"));
     }
 
     @Test

602-spring-data-rest/src/test/java/org/acme/spring/data/rest/BookRepositoryTest.java

@@ -10,6 +10,7 @@
 import java.util.List;
 
 import org.acme.spring.data.rest.containers.PostgreSqlDatabaseTestResource;
+import org.apache.http.HttpStatus;
 import org.junit.Assert;
 import org.junit.jupiter.api.Test;
 
@@ -117,10 +118,11 @@ void testRepositoryValidator() throws InterruptedException{
                 .body("{\"name\": \"Q\", \"author\": \"Li\"}")
                 .when().post("/books")
                 .then()
-                .statusCode(500)
-                .body(
-                        containsString("length must be between 2 and 50"),
-                        containsString("propertyPath=name")
-                );
+                .statusCode(HttpStatus.SC_BAD_REQUEST);
+                // TODO: Body assertion is not working caused by https://github.com/quarkusio/quarkus/issues/15492
+                // .body(
+                //        containsString("length must be between 2 and 50"),
+                //        containsString("propertyPath=name")
+                //);
     }
 }

602-spring-data-rest/src/test/java/org/acme/spring/data/rest/LibraryRepositoryTest.java

@@ -3,6 +3,7 @@
 import io.quarkus.test.common.QuarkusTestResource;
 import io.quarkus.test.junit.QuarkusTest;
 import org.acme.spring.data.rest.containers.PostgreSqlDatabaseTestResource;
+import org.apache.http.HttpStatus;
 import org.junit.jupiter.api.Test;
 
 import static io.restassured.RestAssured.given;
@@ -79,9 +80,10 @@ void testRepositoryValidator() throws InterruptedException{
                 .body("{\"name\": \"\"}")
                 .when().post("/library")
                 .then()
-                .statusCode(500)
-                .body(
-                        containsString("Name may not be blank")
-                );
+                .statusCode(HttpStatus.SC_BAD_REQUEST);
+                // TODO: Body assertion is not working caused by https://github.com/quarkusio/quarkus/issues/15492
+                //.body(
+                //        containsString("Name may not be blank")
+                //);
     }
 }

602-spring-data-rest/src/test/java/org/acme/spring/data/rest/NativeLibraryRepositoryTestIT.java

@@ -1,6 +1,5 @@
 package org.acme.spring.data.rest;
 
-import io.quarkus.test.common.QuarkusTestResource;
 import io.quarkus.test.junit.NativeImageTest;
 
 @NativeImageTest