Remove excessive test and todo note in PostgresPoolTest

Author: gtroitsk

303-quarkus-vertx-sql/src/test/java/io/quarkus/qe/vertx/sql/dbpool/PostgresPoolTest.java

@@ -4,19 +4,13 @@
 import static org.hamcrest.Matchers.greaterThanOrEqualTo;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
 
 import java.time.Duration;
-import java.time.OffsetDateTime;
-import java.util.ArrayList;
-import java.util.List;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import org.eclipse.microprofile.config.inject.ConfigProperty;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.MethodOrderer.OrderAnnotation;
 import org.junit.jupiter.api.Order;
@@ -26,9 +20,7 @@
 import io.quarkus.qe.vertx.sql.test.resources.PostgresqlTestProfile;
 import io.quarkus.test.junit.QuarkusTest;
 import io.quarkus.test.junit.TestProfile;
-import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.Uni;
-import io.vertx.core.Handler;
 import io.vertx.core.impl.logging.Logger;
 import io.vertx.core.impl.logging.LoggerFactory;
 import io.vertx.core.json.JsonArray;
@@ -38,7 +30,6 @@
 import io.vertx.mutiny.ext.web.client.WebClient;
 import io.vertx.mutiny.ext.web.client.predicate.ResponsePredicate;
 import io.vertx.mutiny.pgclient.PgPool;
-import io.vertx.mutiny.sqlclient.Row;
 import io.vertx.mutiny.sqlclient.RowSet;
 
 import jakarta.inject.Inject;
@@ -135,47 +126,6 @@ public void checkIdleExpirationTime() throws InterruptedException {
         assertEquals(doneIdleExpired.getCount(), 0, "Missing doneIdleExpired query.");
     }
 
-    @Test
-    @DisplayName("Idle issue: Fail to read any response from the server, the underlying connection might get lost unexpectedly.")
-    @Order(3)
-    @Disabled("Takes too much time and is fixed by Vertx 4.1")
-    public void checkBorderConditionBetweenIdleAndGetConnection() {
-        try {
-            long idleMs = TimeUnit.SECONDS.toMillis(idle);
-            latch = new CountDownLatch(1); // ignore, this test will run until Timeout or get an error occurs.
-            AtomicInteger at = new AtomicInteger(0);
-            Handler<Long> handler = l -> {
-                LOGGER.info("###################################################: ");
-                Multi.createFrom().range(1, 3)
-                        .concatMap(n -> {
-                            LOGGER.info("Connection #" + at.incrementAndGet());
-                            return postgresql.preparedQuery("SELECT CURRENT_TIMESTAMP")
-                                    .execute().onFailure().invoke(error -> {
-                                        LOGGER.info("Error: " + at.get());
-                                        LOGGER.error("Error on query: '" + error.getMessage() + "'");
-                                        latch.countDown();
-                                        fail(error.getMessage());
-                                    }).map(RowSet::iterator).onItem().transform(iterator -> {
-                                        OffsetDateTime result = OffsetDateTime.now();
-                                        if (iterator.hasNext()) {
-                                            Row row = iterator.next();
-                                            LOGGER.info("Result : " + at.get() + " : " + row.getOffsetDateTime(0));
-                                            result = row.getOffsetDateTime(0);
-                                        }
-                                        return result;
-                                    }).toMulti();
-                        }).collect().in(ArrayList::new, List::add).subscribe().with(re -> {
-                            LOGGER.info("Subscribe success: -> " + re.get(0));
-                        }, Throwable::printStackTrace);
-            };
-            Vertx.vertx().setPeriodic(idleMs + 3, l -> handler.handle(l));
-            await(5, TimeUnit.MINUTES);
-        } catch (IllegalStateException ex) {
-        } finally {
-            assertEquals(1, latch.getCount(), "An unexpected error was thrown.");
-        }
-    }
-
     private Uni<Long> activeConnections() {
         return postgresql.query(
                 "SELECT count(*) as active_con FROM pg_stat_activity where application_name like '%vertx%'")
@@ -195,7 +145,7 @@ protected String getAppEndpoint() {
     }
 
     private boolean checkDbActiveConnections(long active) {
-        return active <= datasourceMaxSize + (7); // TODO: double check this condition ... this magical number is scary!.
+        return active <= datasourceMaxSize;
     }
 
 }