resteasy-reactive-client reads full response bytes in memory

[Treiblesschorle]

Hi, it seems that making a GET call like

try (final var client = ClientBuilder.newClient()) {
    try (final var downloadResponse = client.target(downloadUri).request(MediaType.APPLICATION_OCTET_STREAM).get()) {
        System.out.println(downloadResponse.getStatus());
    }
}

using the client from

<dependency>
	<groupId>io.quarkus</groupId>
	<artifactId>quarkus-rest-client</artifactId>
	<version>3.20.3</version>
</dependency>

seems to read the full response bytes into memory on the get() call, which leads to an OOM in my quarkus application. This seems to have started when we migrated to quarkus-rest, i.e. using

<groupId>org.jboss.resteasy</groupId>
<artifactId>resteasy-client</artifactId>

the get() call does not seem to read the whole response in memory. I couldn't find documentation about this. Is this behavior expected? And can the client be somehow configured or do I need to use a different client?

[quarkus-bot[bot]]

/cc @FroMage (rest), @geoand (rest)

[geoand]

What is it exactly that you are trying to achieve?

[Treiblesschorle]

I'm downloading a potentially large file, i.e. I'm getting a stream downloadResponse.readEntity(InputStream.class). Which is a problem if it is now completely buffered in memory.

[geoand]

You need to use client.target(downloadUri).request(MediaType.APPLICATION_OCTET_STREAM).get(InputStream.class)

[Treiblesschorle]

Thanks, that works. I missed that API. One thing I noticed, though, is that the close() call on the resulting stream will block until the whole response is read. I want to read the whole thing anyway, but maybe interesting for someone else that reads this thread.
However, would it maybe make sense to document this change somewhere? E.g. here https://quarkus.io/guides/rest-migration

[geoand]

Very interesting!

That sounds like a bug to be honest. Mind opening an issue with a sample project I can use to see it in action?

[Treiblesschorle]

Issue: #50889

To clarify, with

However, would it maybe make sense to document this change somewhere? E.g. here https://quarkus.io/guides/rest-migration

I mostly meant the behavior change of get(InputStream.class) vs get().readEntity(InputStream.class)

[geoand]

That does make sense. Do you want to do a PR adding that?