[#38] Fix validations

* Comparison needs to be made with correct size in case size is not specified (defaults to 10).

Author: qubicmio

v2/grpc/validations.go

@@ -22,10 +22,13 @@ func validatePagination(page *api.Pagination) (from uint32, size uint32, err err
 	if size > maxPageSize {
 		return 0, 0, fmt.Errorf("size [%d] exceeds maximum [%d]", size, maxPageSize)
 	}
+	if size == 0 {
+		size = defaultPageSize
+	}
 	if from+size > maxHitsSize {
 		return 0, 0, fmt.Errorf("offset [%d] + size [%d] exceeds maximum [%d]", from, size, maxHitsSize)
 	}
-	return from, If(size > 0, size, defaultPageSize), nil
+	return from, size, nil
 }
 
 var allowedTermFilters = [4]string{"source", "destination", "amount", "inputType"}

v2/grpc/validations_test.go

@@ -41,6 +41,18 @@ func TestValidations_validatePagination_largetOffsetPlusPageSize(t *testing.T) {
 	})
 	require.NoError(t, err)
 
+	_, _, err = validatePagination(&api.Pagination{
+		Offset: uint32Pointer(9999),
+		Size:   uint32Pointer(1),
+	})
+	require.NoError(t, err)
+
+	_, _, err = validatePagination(&api.Pagination{
+		Offset: uint32Pointer(9999),
+		Size:   uint32Pointer(0), // defaults to 10
+	})
+	require.ErrorContains(t, err, "exceeds maximum [10000]")
+
 	_, _, err = validatePagination(&api.Pagination{
 		Offset: uint32Pointer(9990),
 		Size:   uint32Pointer(11),