Skip to content

reveal more informative source code in printing vignette #821

Description

@corybrunson

I just noticed that the source code displays in the printing vignette, as also seen on the website, merely reveals that print.tbl() calls print_tbl() and that format.tbl() calls format_tbl(). The surrounding text seems to assume that the reader can see how the print() method calls the format() method and can see the detailed procedures of the format() method, and i think that would be more useful source to display.

Perhaps the vignette was written when the S3 methods didn't rely on these internal helpers. If the current call stack (?) is likely to last a while, then this can be easily fixed, and i'd be glad to submit a PR. If the internals might change soon, though, then could another approach persist through such changes?

Thanks a lot. The vignettes for this package have been indispensable, in part due to my unfamiliarity with the tools and in part just because how clear and informative they are.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions